Skip to content

web: Fix navigating to URLs with query params #22458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dinnerbone merged 1 commit into from
Dec 13, 2025
+17 −0
Merged

web: Fix navigating to URLs with query params #22458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions web/src/navigator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,23 @@ impl NavigatorBackend for WebNavigatorBackend {
form.set_target(target);
}

if navmethod == NavigationMethod::Get {
// Browsers will clobber any query string with "the whole form input", so we need to re-add them here
for (key, value) in url.query_pairs() {
let hidden: HtmlInputElement = document
.create_element("input")
.expect("create_element() must succeed")
.dyn_into()
.expect("create_element(\"input\") didn't give us an input");

hidden.set_type("hidden");
hidden.set_name(&key);
hidden.set_value(&value);

let _ = form.append_child(&hidden);
}
}

for (key, value) in formvars {
let hidden: HtmlInputElement = document
.create_element("input")
Expand Down
Loading