Skip to content

Conversation

@Dinnerbone
Copy link
Contributor

This fixes an issue reported on Discord.

When we try to navigate to a url that already has a query string, it will be removed unless the method is POST.

@Dinnerbone Dinnerbone added A-web Area: Web & Extensions T-fix Type: Bug fix (in something that's supposed to work already) labels Dec 8, 2025
@kjarosh
Copy link
Member

kjarosh commented Dec 9, 2025

I think we can add a web test for it, it should be pretty straightforward

@n0samu
Copy link
Member

n0samu commented Dec 10, 2025

Why do we use a hidden form submission to navigate to URL rather than something like window.location.assign()?

@Dinnerbone
Copy link
Contributor Author

Why do we use a hidden form submission to navigate to URL rather than something like window.location.assign()?

There's a path that does that, but it seems to use this if there's a chance that it might not be GET or wants to encode additional parameters. I guess we could specialize that further if it's GET+_self+no arguments, but, this code path should work in any case.

@Dinnerbone
Copy link
Contributor Author

I think we can add a web test for it, it should be pretty straightforward

I'm struggling to make a test for this, webdriverio (or specifically, the browsers themselves) do not seem to like pages navigating if not done by the driver itself.

@Dinnerbone Dinnerbone enabled auto-merge (rebase) December 13, 2025 13:30
@Dinnerbone Dinnerbone merged commit 008047e into master Dec 13, 2025
26 checks passed
@Dinnerbone Dinnerbone deleted the navigate-with-query branch December 13, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-web Area: Web & Extensions T-fix Type: Bug fix (in something that's supposed to work already)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants