Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to rubygems.org footer #1722

Merged
merged 2 commits into from
May 7, 2018
Merged

updates to rubygems.org footer #1722

merged 2 commits into from
May 7, 2018

Conversation

rubymorillo
Copy link
Contributor

Hey team,

Per rubycentral/board#5 (and as seen in #1721), here are some copy updates to the RubyGems.org footer. It details the partnership between Ruby Central, Fastly, and Ruby Together.

@rubymorillo
Copy link
Contributor Author

cc @indirect

@segiddins segiddins requested a review from indirect May 5, 2018 05:42
<%= link_to "Fastly" "https://www.fastly.com/") %> provides bandwidth and CDN support,
<%= link_to "Ruby Central" "http://www.rubycentral.org/") %> covers infrastructure costs, and
<%= link_to "Ruby Together" "https://rubytogether.org/?source=rubygems" %> funds ongoing development and ops work.
<%= link_to "Learn more about our sponsors and how they work together." page_path("sponsors") %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, syntax here is all over the place. can we please fix it?
link_to

@rubymorillo
Copy link
Contributor Author

@sonalkr132 hey Aditya, thank you! Just updated again, waiting your review

@indirect
Copy link
Member

indirect commented May 7, 2018

Awesome, thanks @rubymorillo!

@adarsh
Copy link
Contributor

adarsh commented May 8, 2018

Just a note: I believe this language is out of date from what @evanphx and RT had discussed in rubycentral/board#8 which I proposed changing in the README.md in #1720.

Can we update to match that language here in the footer as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants