Skip to content

Removed deprecated actionlib_msgs #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 1, 2025

No description provided.

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde self-assigned this May 1, 2025
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to remove this message type. just a background check, why do we keep this message type? mean what for?

@ahcorde
Copy link
Contributor Author

ahcorde commented May 1, 2025

FYI @tfoote @mjcarroll

@ahcorde ahcorde requested a review from tfoote May 2, 2025 13:12
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was kept around to help with the ROS 1 to ROS 2 migration. In ROS 2 we made actions first class so instead of being actionlib doing the implementation the implementation is in the client libraries. The new messages are in https://index.ros.org/p/action_msgs/

Having these messages enabled at least introspection of ROS 1 actionlib operations. But now that ROS 1 is going EOL there's no requirement for keeping it around.

It would be good to at least ticket the few remaining dependencies on the deprecated package. https://index.ros.org/p/actionlib_msgs/#rolling-deps I suspect that they have old dependencies that can just be cleaned up.

@fujitatomoya
Copy link
Collaborator

@tfoote understood, thanks for the explanation.

@ahcorde
Copy link
Contributor Author

ahcorde commented May 6, 2025

@ahcorde
Copy link
Contributor Author

ahcorde commented May 6, 2025

Running full CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit edb0a3a into rolling May 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants