Keep package.xml and cmake versions in sync #232
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Use validate_package_xml action from gazebo-tooling/action-gz-ci. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
saikishor
reviewed
Dec 5, 2025
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
The changes look good to me, this should make it consistent
Contributor
Author
|
an alternative approach is in #233 |
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the package version is set in both package.xml and the CMakeLists.txt file and it's easy for them to get out of sync. This adds a github workflow from the gazebo-tooling org to check that the cmake and package.xml versions are the same and updates the cmake version, since they are currently out of sync.
project()invocation with theVERSIONkeyword in order to support the expectations of the github workflow to be used. Keep the sameURDF_*_VERSIONcmake variables.cc @saikishor