Fix: Add covariance magnitude (Issue #5611) #5683
Open
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0s4ngeles
force-pushed
the
fix/covariance-validation-5611
branch
from
4114f9f to
e060dde
Compare
Signed-off-by: ubuntu <[email protected]>
Signed-off-by: ubuntu <[email protected]>
Signed-off-by: ubuntu <[email protected]>
Signed-off-by: ubuntu <[email protected]>
r0s4ngeles
force-pushed
the
fix/covariance-validation-5611
branch
from
e060dde to
761c40e
Compare
SteveMacenski
requested changes
Nov 14, 2025
| } | ||
|
|
||
| const double MAX_COVARIANCE = 1e6; | ||
| const double MIN_COVARIANCE = 1e-4; |
Member
There was a problem hiding this comment.
A zero-value is possible / valid
| if (!validateMsg(element)) {return false;} | ||
|
|
||
| if (std::abs(element) > MAX_COVARIANCE || std::abs(element) < MIN_COVARIANCE) { | ||
| // Reject extreme values (security: prevent DoS attacks) |
Member
There was a problem hiding this comment.
How would this be a DoS? I think this should just mention checking for covar valid range
Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: r0s4ngeles <[email protected]>
Contributor
|
@r0s4ngeles, your PR has failed to build. Please check CI outputs and resolve issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.