Skip to content

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Oct 13, 2025

I rewrote the tests using the idea from https://docs.ros.org/en/rolling/Tutorials/Intermediate/Testing/Integration.html

First idea:

This all did not help, but adding a timer re-sending the actual_joint_states did the job.

Fixes #21 #22 #23

2a6f1a8 fixes also #10

Then I realized that we don't even test if commands are received

Current idea:

  • use topic_tools relay executable instead of custom python robot node, and mirror commands to states
  • Adapt the example_position executable from gz_ros2_control_demos to test if the commands from the controllers are processed correctly

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.44%. Comparing base (378507e) to head (a904bd7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ardware_interface/test/rrr/jtc_client_position.cpp 66.66% 29 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
+ Coverage   38.62%   61.44%   +22.82%     
===========================================
  Files           2        3        +1     
  Lines         145      249      +104     
  Branches       34       42        +8     
===========================================
+ Hits           56      153       +97     
+ Misses         80       75        -5     
- Partials        9       21       +12     
Flag Coverage Δ
unittests 61.44% <66.66%> (+22.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ardware_interface/test/rrr/jtc_client_position.cpp 66.66% <66.66%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the test @christophfroehlich! Few small comments but otherwise looks good.

@MarqRazz MarqRazz requested a review from JafarAbdi October 15, 2025 14:40
Copy link
Collaborator

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry haven't had time to look into PRs, life is busy 🫠. Hopefully will be better soon

@christophfroehlich christophfroehlich merged commit cd86811 into main Oct 16, 2025
28 of 29 checks passed
@christophfroehlich christophfroehlich deleted the fix/integration/test branch October 16, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI build job rolling/testing failed! CI build job kilted/main failed! ros2_control integration test is flaky Incompatible with RHEL

4 participants