-
Notifications
You must be signed in to change notification settings - Fork 2
Fix integration test #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
===========================================
+ Coverage 38.62% 61.44% +22.82%
===========================================
Files 2 3 +1
Lines 145 249 +104
Branches 34 42 +8
===========================================
+ Hits 56 153 +97
+ Misses 80 75 -5
- Partials 9 21 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the test @christophfroehlich! Few small comments but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sorry haven't had time to look into PRs, life is busy 🫠. Hopefully will be better soon
I rewrote the tests using the idea from https://docs.ros.org/en/rolling/Tutorials/Intermediate/Testing/Integration.html
First idea:
This all did not help, but adding a timer re-sending the actual_joint_states did the job.
Fixes #21 #22 #23
2a6f1a8 fixes also #10
Then I realized that we don't even test if commands are received
Current idea: