Fix RCLCPP_WARN_ONCE within handle
#2630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
the
backport-kilted
github-actions
bot
requested review from
DasRoteSkelett,
arne48,
bmagyar,
erickisos,
fmauch,
olivier-stasse and
saikishor
saikishor
approved these changes
Oct 7, 2025
|
@christophfroehlich why not backport this to Jazzy too? |
the macro is not available there since #2360 was not backported |
christophfroehlich
merged commit b53dd8e
into
ros-controls:master
12 of 16 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
(cherry picked from commit b53dd8e)
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCLCPP_*_ONCE logging macros are global, which means this will be triggered only once for the very first handle hitting this.
Unless ros2/rclcpp#2587 is fixed upstream, we have to deal with it in the application code.
I also added a missing include and reformatted the log strings.