Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 8, 2025

RCLCPP_*_ONCE logging macros are global, which means this will be triggered only once for the very first handle hitting this.

Unless ros2/rclcpp#2587 is fixed upstream, we have to deal with it in the application code.

I also added a missing include and reformatted the log strings.


This is an automatic backport of pull request #2630 done by Mergify.

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.34%. Comparing base (4c48632) to head (a121415).
⚠️ Report is 2 commits behind head on kilted.

Files with missing lines Patch % Lines
...re_interface/include/hardware_interface/handle.hpp 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted    #2643      +/-   ##
==========================================
- Coverage   89.35%   89.34%   -0.01%     
==========================================
  Files         148      148              
  Lines       16980    16985       +5     
  Branches     1416     1417       +1     
==========================================
+ Hits        15172    15176       +4     
  Misses       1256     1256              
- Partials      552      553       +1     
Flag Coverage Δ
unittests 89.34% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/test/test_handle.cpp 98.51% <100.00%> (+0.03%) ⬆️
...re_interface/include/hardware_interface/handle.hpp 86.77% <42.85%> (-0.62%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit d64ad3b into kilted Oct 8, 2025
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-2630 branch October 8, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant