Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JointControllerStateArray for group controllers #50

Open
wants to merge 2 commits into
base: kinetic-devel
Choose a base branch
from

Conversation

Smilels
Copy link

@Smilels Smilels commented Dec 6, 2020

No description provided.

@bmagyar
Copy link
Member

bmagyar commented Jan 20, 2021

Could you elaborate please?

@Smilels
Copy link
Author

Smilels commented Jan 27, 2021

Could you elaborate please?

Yes.
JointControllerState is designed to present the current controller state of one joint.
But for most of the robot arms or multi-fingered robotic hands, we don't want to use 6 or 5 publishers or subscribers to publish or get the controller states, especially when people use group controllers, for example, JointGroupVelocityController on PR2 or JointGroupEffortController on Shadow hand.
Therefore, I think an array message will be helpful here.

@bmagyar
Copy link
Member

bmagyar commented Jan 28, 2021

This sounds very reasonable. Do you have a Pull Request on JointGroupVelocityController and friends that are already using this message? I would prefer to wait with merging this until there's a PR showing it working.

@Smilels
Copy link
Author

Smilels commented Jan 28, 2021

This sounds very reasonable. Do you have a Pull Request on JointGroupVelocityController and friends that are already using this message? I would prefer to wait with merging this until there's a PR showing it working.

I am using PR2 but PR2 has its pr2_controllers. Therefore I only gave two pull requests for PR2.
PR2/pr2_controllers#400
PR2/pr2_robot#264

In this pull [request], I also built a new ros message (pr2_controllers_msgs/msg/JointControllerStateArray.msg).

I have verified that this JointGroupVelocityController works well on PR2. Please see this video https://www.youtube.com/watch?v=rAj2IWl2ezs.

I haven't tested JointGroupVelocityController on other robots. I am thinking to write a JointGroupEffortController interface for Shadow hand.

@@ -0,0 +1,2 @@
Header header
JointControllerState[] controllestate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Smilels The identifier looks like a typo. I would expect controller_state ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. I have updated the variable name to controller_state.

Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Mar 31, 2025
Copy link

mergify bot commented Mar 31, 2025

@Smilels, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to kinetic-devel, but it must be in master
to have these changes reflected into new distributions.

@github-actions github-actions bot removed the stale label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants