Skip to content

[cling] Pre LLVM20 changes that can go before the actual upgrade #19248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devajithvs merged 4 commits into from
Jul 2, 2025
Merged

[cling] Pre LLVM20 changes that can go before the actual upgrade #19248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef1016a
[TCling] Prevent conflicts with LLVM `indent()`
devajithvs Feb 24, 2025
fa6151d
[cling] Remove the usage of `.equals`
devajithvs Apr 1, 2025
983a3d4
[cling] Add null check for scope in `GetFullyQualifiedNameSpecifier`
devajithvs Apr 16, 2025
4f10712
[cling] Suppress unused argument warning
devajithvs Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/metacling/src/TClingCallFunc.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ C++ interpreter and the Clang C++ compiler, not CINT.
#include <sstream>

using namespace ROOT;
using namespace llvm;
using namespace clang;
using llvm::APSInt, llvm::raw_string_ostream;
using std::string, std::map, std::ostringstream, std::make_pair;

static unsigned long long gWrapperSerial = 0LL;
Expand Down
4 changes: 0 additions & 4 deletions interpreter/cling/lib/Interpreter/CIFactory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,10 +1407,6 @@ namespace {
#endif

if (!COpts.HasOutput || !HasInput) {
// suppress the warning "argument unused during compilation: -c" of the
// device interpreter instance
if (!COpts.CUDADevice)
argvCompile.push_back("-c");
argvCompile.push_back("-");
}

Expand Down
2 changes: 1 addition & 1 deletion interpreter/cling/lib/Interpreter/Value.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ namespace cling {
const clang::BuiltinType *BT = getType()->castAs<clang::BuiltinType>();
clang::PrintingPolicy Policy = getASTContext().getPrintingPolicy();
#endif // NDEBUG
assert(BT->getName(Policy).equals(Type));
assert(BT->getName(Policy) == Type);
}

static clang::QualType getCorrespondingBuiltin(clang::ASTContext &C,
Expand Down
2 changes: 2 additions & 0 deletions interpreter/cling/lib/Utils/AST.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,8 @@ namespace utils {
static
NestedNameSpecifier* GetFullyQualifiedNameSpecifier(const ASTContext& Ctx,
NestedNameSpecifier* scope) {
if (!scope)
return nullptr;
// Return a fully qualified version of this name specifier
if (scope->getKind() == NestedNameSpecifier::Global) {
// Already fully qualified.
Expand Down
Loading