Skip to content

Conversation

@devajithvs
Copy link
Contributor

@devajithvs devajithvs commented Jul 2, 2025

This Pull request:

Changes that can go before: #19242

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

Use explicit LLVM components to avoid namespace pollution
and name conflicts after upgrading to LLVM20.

Ref:
llvm/llvm-project@2731be7
Adds a check to ensure 'scope' is not null before use,
preventing potential crashes after upgrading to LLVM20
Suppress the warning: `argument unused during compilation: -c`

`-c/-S` will not be claimed after the LLVM commit:
llvm/llvm-project@6461e53
@devajithvs devajithvs requested review from dpiparo and pcanal as code owners July 2, 2025 09:10
@devajithvs devajithvs requested review from dpiparo, hahnjo, pcanal and vgvassilev and removed request for dpiparo and pcanal July 2, 2025 09:11
@devajithvs devajithvs self-assigned this Jul 2, 2025
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Test Results

    20 files      20 suites   3d 5h 23m 30s ⏱️
 3 091 tests  3 091 ✅ 0 💤 0 ❌
60 225 runs  60 225 ✅ 0 💤 0 ❌

Results for commit 4f10712.

@devajithvs devajithvs merged commit 70c900f into root-project:master Jul 2, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants