Back to peer deps #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 3ee3fbe. I'm putting this back the way it was. In retrospect, this way of doing it seems more consistent with the JS ecosystem. The package should specify the versions it has been tested and known to work with explicitly.
Clean up old no-longer supported beta versions in peer deps. It will install even if there isn't a direct match so I think it's fine to leave these out for convenience.
arv
reviewed
Nov 17, 2022
| "homepage": "https://replicache.dev", | ||
| "repository": "github:rocicorp/replicache-react", | ||
| "main": "out/index.js", | ||
| "module": "out/index.mjs", |
Contributor
Author
There was a problem hiding this comment.
I think the revert command did that or something. Wasn't purposeful.
Contributor
|
Let's do #38 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.