chore: specify types needed directly. #38
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure getting them through v10 of Replicache was doing the right thing. When I install replicache-react and replicache v12 together in an app, I only see one version of replicache, v12. And replicache-react doesn't re-include the required types in its own .d.ts file. So unless tsc is being very fancy (which, I dunno, maybe it is) and getting the old version of replicache behind the scenes somehow, then I think this is using the wrong types. Anyway, this is more direct way to do what was meant.
Contributor
|
I like this. This looks like it should work. |
Contributor
|
Let's do this instead of #40 We can now remove the replicache deps |
This was referenced Nov 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure getting them through v10 of Replicache was doing the right thing. When I install replicache-react and replicache v12 together in an app, I only see one version of replicache, v12. And replicache-react doesn't re-include the required types in its own .d.ts file. So unless tsc is being very fancy (which, I dunno, maybe it is) and getting the old version of replicache behind the scenes somehow, then I think this is using the wrong types.
Anyway, this is more direct way to do what was meant.