Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/mx-1768 prep url search params #241

Merged
merged 16 commits into from
Feb 10, 2025
Merged

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Jan 28, 2025

PR Context

  • (another) prep for implementing url search parameters

Changes

  • simplify some styles and update look and feel to be more inline with mex-drop
  • use more idiomatic variables for styling elements with colors or spacing

Removed

  • remove dependency to reflex-chakra, use default checkboxes instead

Base automatically changed from feature/mex-common-0.48.0 to main January 29, 2025 10:58
@cutoffthetop cutoffthetop force-pushed the feature/mx-1768-url-params-2 branch from 42ea1a4 to ee088a7 Compare January 30, 2025 11:59
cutoffthetop added a commit that referenced this pull request Feb 4, 2025
### PR Context

- prep for #241

### Changes

- update mex-common to version 0.49.3
- BREAKING: you must start the local dev mode simply with `pdm run
editor` (no 2nd run)
- BREAKING: rename postfix_badge to render_badge (for consistency)
- simplify some styles

### Fixed

- decorate state handlers with `@rx.event` to satisfy new reflex
versions
- explicitly define cache strategies for vars with
`@rx.var(cache=False)`
@cutoffthetop cutoffthetop changed the title feature/mx-1768 url search params feature/mx-1768 prep url search params Feb 5, 2025
cutoffthetop added a commit to robert-koch-institut/mex-drop that referenced this pull request Feb 7, 2025
# PR Context

- harmonize mex-drop setup and style further with mex-editor
- so that we can (maybe) have a mex ui-kit repo at some point
- setup inspo
robert-koch-institut/mex-editor#245
- style inspo
robert-koch-institut/mex-editor#241

# Added

- update mex-common to version 0.49.3
- BREAKING: you must start the local dev mode simply with `pdm run drop`
(no 2nd run)
- move custom backend exception handler to its own module
- move custom api code to its own package `mex.drop.api`
- align general layout functions (page, logo, navbar, etc) with
mex-editor
- align login component and navbar state handling with mex-editor
- update styling with more idiomatic variable syntax and responsive
scaling

# Fixed
- decorate state handlers with `@rx.event` to satisfy new reflex
versions
@cutoffthetop cutoffthetop merged commit 4980770 into main Feb 10, 2025
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1768-url-params-2 branch February 10, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants