Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/mx-1768 prepare url search params #245

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Feb 4, 2025

PR Context

Changes

  • update mex-common to version 0.49.3
  • BREAKING: you must start the local dev mode simply with pdm run editor (no 2nd run)
  • BREAKING: rename postfix_badge to render_badge (for consistency)
  • simplify some styles

Fixed

  • decorate state handlers with @rx.event to satisfy new reflex versions
  • explicitly define cache strategies for vars with @rx.var(cache=False)

@cutoffthetop cutoffthetop force-pushed the feature/mx-1768-prep-1 branch from 62eb89a to b4e7c09 Compare February 4, 2025 09:09
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Cool typer lib. Can we replace click with this?

@cutoffthetop
Copy link
Contributor Author

Nice. Cool typer lib. Can we replace click with this?

typer is built on click. but yeah, it may help with MX-1707

@cutoffthetop cutoffthetop merged commit ec404fc into main Feb 4, 2025
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1768-prep-1 branch February 4, 2025 09:50
cutoffthetop added a commit to robert-koch-institut/mex-drop that referenced this pull request Feb 7, 2025
# PR Context

- harmonize mex-drop setup and style further with mex-editor
- so that we can (maybe) have a mex ui-kit repo at some point
- setup inspo
robert-koch-institut/mex-editor#245
- style inspo
robert-koch-institut/mex-editor#241

# Added

- update mex-common to version 0.49.3
- BREAKING: you must start the local dev mode simply with `pdm run drop`
(no 2nd run)
- move custom backend exception handler to its own module
- move custom api code to its own package `mex.drop.api`
- align general layout functions (page, logo, navbar, etc) with
mex-editor
- align login component and navbar state handling with mex-editor
- update styling with more idiomatic variable syntax and responsive
scaling

# Fixed
- decorate state handlers with `@rx.event` to satisfy new reflex
versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants