Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to Issue 19 #20

Merged
merged 3 commits into from
Apr 12, 2015
Merged

Fix to Issue 19 #20

merged 3 commits into from
Apr 12, 2015

Conversation

RaineForest
Copy link
Member

^ title

@RaineForest RaineForest mentioned this pull request Apr 12, 2015
Open
@chrissprague
Copy link
Member

What is the purpose of title=""? Can this be accomplished by just not including the title attribute in the first place, or is this safer?

chrissprague added a commit that referenced this pull request Apr 12, 2015
@chrissprague
Merge pull request #20 from rit-csc/Issue-19
e15720f 
Fix to Issue 19
@chrissprague chrissprague merged commit e15720f into staging Apr 12, 2015
@khipkin khipkin deleted the Issue-19 branch April 13, 2015 02:06
@RaineForest
Copy link
Member Author

It's to make sure that the title text (the tooltip, the thing specifically pointed out in #19) doesn't appear by setting it to null.

@chrissprague
Copy link
Member

@RaineForest right, but is explicitly saying title="" different than just excluding the title tag in the first place, and if so, how?

@RaineForest
Copy link
Member Author

A null title specifies an empty string, no title is undefined and left to the discretion of the browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaineForest @chrissprague