fix: no percent symbol in variable qubit outputs #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [this pyQuil issue](rigetti/pyquil#1673), we saw that the v3 version of pyQuil can't parse `DEFCALS` with a variable qubit; e.g. ``` DEFCAL I %q: DELAY q 4e-8 ``` would cause pyQuil to crash, complaining about the `%` symbol. While the [spec claims](https://quil-lang.github.io/#12-6Defining-Calibrations) this is a valid way of writing variable qubits for calibrations, the percent symbol prefix is only otherwise used for parameters (e.g. angles for rotational gates), not for qubits themselves. This PR changes how variable qubits are printed, removing the `%` prefix. If this change is merged into `quil-rs`, chances are we probably want to update the spec accordingly as well.
Shadow53
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pyQuil issue, we saw that the v3 version of pyQuil can't parse
DEFCALSwith a variable qubit; e.g.would cause pyQuil to crash, complaining about the
%symbol. While the spec claims this is a valid way of writing variable qubits for calibrations, the percent symbol prefix is only otherwise used for parameters (e.g. angles for rotational gates), not for qubits themselves. This PR changes how variable qubits are printed, removing the%prefix.If this change is merged into
quil-rs, chances are we probably want to update the spec accordingly as well.