Merge pull request #293 from rigetti/variable-qubit

fix: no percent symbol in variable qubit outputs
rigetti · Oct 10, 2023 · 4807de0 · 4807de0
2 parents eb30581 + 9a82a2b
commit 4807de0
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 16 deletions.
diff --git a/quil-rs/src/instruction/mod.rs b/quil-rs/src/instruction/mod.rs
@@ -219,23 +219,16 @@ fn write_qubits(
     Ok(())
 }
 
-/// Write qubits as a Quil parameter list, where each variable qubit must be prefixed with a `%`
-/// and all are prefixed with ` `. Return an error if any is a qubit placeholder.
+/// Write qubits as a Quil parameter list, where all are prefixed with ` `.
 fn write_qubit_parameters(
     f: &mut impl std::fmt::Write,
     fall_back_to_debug: bool,
     qubits: &[Qubit],
 ) -> ToQuilResult<()> {
     for qubit in qubits.iter() {
-        match qubit {
-            Qubit::Variable(var) => write!(f, " %{var}")?,
-            other => {
-                write!(f, " ")?;
-                other.write(f, fall_back_to_debug)?;
-            }
-        }
+        write!(f, " ")?;
+        qubit.write(f, fall_back_to_debug)?;
     }
-
     Ok(())
 }
 

diff --git a/...apshots/quil_rs__program__calibration__tests__expansion@Calibration-Param-Precedence.snap b/...apshots/quil_rs__program__calibration__tests__expansion@Calibration-Param-Precedence.snap
@@ -1,8 +1,8 @@
 ---
 source: quil-rs/src/program/calibration.rs
-expression: calibrated_program.to_string()
+expression: calibrated_program.to_quil_or_debug()
 ---
-DEFCAL RX(%theta) %qubit:
+DEFCAL RX(%theta) qubit:
 	PULSE 1 "xy" gaussian(duration: 1, fwhm: 2, t0: 3)
 DEFCAL RX(%theta) 0:
 	PULSE 2 "xy" gaussian(duration: 1, fwhm: 2, t0: 3)

diff --git a/...snapshots/quil_rs__program__calibration__tests__expansion@Calibration-Variable-Qubit.snap b/...snapshots/quil_rs__program__calibration__tests__expansion@Calibration-Variable-Qubit.snap
@@ -1,8 +1,8 @@
 ---
 source: quil-rs/src/program/calibration.rs
-expression: calibrated_program.to_string()
+expression: calibrated_program.to_quil_or_debug()
 ---
-DEFCAL I %q:
+DEFCAL I q:
 	DELAY q 4e-8
 DELAY 0 4e-8
 
diff --git a/...-rs/src/program/snapshots/[email protected] b/...-rs/src/program/snapshots/[email protected]
@@ -1,8 +1,8 @@
 ---
 source: quil-rs/src/program/calibration.rs
-expression: calibrated_program.to_string()
+expression: calibrated_program.to_quil_or_debug()
 ---
-DEFCAL RZ(%theta) %q:
+DEFCAL RZ(%theta) q:
 	SHIFT-PHASE q "rf" -%theta
 SHIFT-PHASE 0 "rf" -pi