Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/project.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"generatedAt":1727177987669,"hasCustomBabel":false,"hasCustomWebpack":false,"hasStaticDirs":false,"hasStorybookEslint":false,"refCount":0,"testPackages":{},"packageManager":{"type":"npm","version":"10.8.2"},"preview":{"usesGlobals":false},"framework":{"name":"@storybook/svelte-vite","options":{}},"builder":"@storybook/builder-vite","renderer":"@storybook/svelte","storybookVersion":"8.2.9","storybookVersionSpecifier":"^8.2.9","language":"typescript","storybookPackages":{"@storybook/addon-essentials":{"version":"8.2.9"},"@storybook/addon-mdx-gfm":{"version":"8.2.9"},"@storybook/blocks":{"version":"8.2.9"},"@storybook/builder-vite":{"version":"8.2.9"},"@storybook/components":{"version":"8.2.9"},"@storybook/manager-api":{"version":"8.2.9"},"@storybook/mdx2-csf":{"version":"1.1.0"},"@storybook/svelte":{"version":"8.2.9"},"@storybook/svelte-vite":{"version":"8.2.9"},"@storybook/test":{"version":"8.2.9"},"@storybook/theming":{"version":"8.2.9"},"storybook":{"version":"8.2.9"}},"addons":{"@storybook/addon-svelte-csf":{"version":"4.1.5"},"@storybook/addon-links":{"version":"8.2.9"},"@storybook/addon-actions":{"version":"8.2.9"},"@storybook/addon-viewport":{"version":"8.2.9"},"@storybook/addon-docs":{"version":"8.2.9"},"@storybook/addon-controls":{"version":"8.2.9"},"@storybook/addon-backgrounds":{"version":"8.2.9"},"@storybook/addon-toolbars":{"version":"8.2.9"},"@storybook/addon-measure":{"version":"8.2.9"},"@storybook/addon-outline":{"version":"8.2.9"},"@storybook/addon-interactions":{"version":"8.2.9"},"@chromatic-com/storybook":{"version":"1.7.0"},"chromatic":{"version":null,"versionSpecifier":"^7.1.0"}}}
{"generatedAt":1729247024480,"hasCustomBabel":false,"hasCustomWebpack":false,"hasStaticDirs":false,"hasStorybookEslint":false,"refCount":0,"testPackages":{},"packageManager":{"type":"npm","version":"10.8.3"},"preview":{"usesGlobals":false},"framework":{"name":"@storybook/svelte-vite","options":{}},"builder":"@storybook/builder-vite","renderer":"@storybook/svelte","storybookVersion":"8.2.9","storybookVersionSpecifier":"^8.2.9","language":"typescript","storybookPackages":{"@storybook/addon-essentials":{"version":"8.2.9"},"@storybook/addon-mdx-gfm":{"version":"8.2.9"},"@storybook/blocks":{"version":"8.2.9"},"@storybook/builder-vite":{"version":"8.2.9"},"@storybook/components":{"version":"8.2.9"},"@storybook/manager-api":{"version":"8.2.9"},"@storybook/mdx2-csf":{"version":"1.1.0"},"@storybook/svelte":{"version":"8.2.9"},"@storybook/svelte-vite":{"version":"8.2.9"},"@storybook/test":{"version":"8.2.9"},"@storybook/theming":{"version":"8.2.9"},"storybook":{"version":"8.2.9"}},"addons":{"@storybook/addon-svelte-csf":{"version":"4.1.5"},"@storybook/addon-links":{"version":"8.2.9"},"@storybook/addon-actions":{"version":"8.2.9"},"@storybook/addon-viewport":{"version":"8.2.9"},"@storybook/addon-docs":{"version":"8.2.9"},"@storybook/addon-controls":{"version":"8.2.9"},"@storybook/addon-backgrounds":{"version":"8.2.9"},"@storybook/addon-toolbars":{"version":"8.2.9"},"@storybook/addon-measure":{"version":"8.2.9"},"@storybook/addon-outline":{"version":"8.2.9"},"@storybook/addon-interactions":{"version":"8.2.9"},"@chromatic-com/storybook":{"version":"1.7.0"},"chromatic":{"version":null,"versionSpecifier":"^7.1.0"}}}
20 changes: 20 additions & 0 deletions src/components/Dianomi/DianomiAd.stories.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<script lang="ts">
import { Story, Meta } from '@storybook/addon-svelte-csf';

// @ts-ignore raw
import adDocs from './stories/docs/dianomi.md?raw';

import DianomiAd from './DianomiAd.svelte';

import { withComponentDocs } from '$lib/docs/utils/withParams.js';

const meta = {
...withComponentDocs(adDocs),
};
</script>

<Meta title="Components/DianomiAd" component="{DianomiAd}" {...meta} />

<Story name="Default">
<DianomiAd />
</Story>
11 changes: 11 additions & 0 deletions src/components/Dianomi/DianomiAd.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<script>
import { onMount } from 'svelte';
onMount(() => {
const script = document.createElement('script');
script.src = 'https://www.dianomi.com/js/contextfeed.js';
script.id = 'dianomi_context_script';
document.head.appendChild(script);
});
</script>

<div class="dianomi_context" data-dianomi-context-id="1948"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this display any visual content? If so, how does that interplay with our existing ad components?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does display the Dianomi sponsorship ads. Please expound on what you meant by interplaying with the existing ad components.

19 changes: 19 additions & 0 deletions src/components/Dianomi/stories/docs/dianomi.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
Add a dianomi ad to your page.

Dianomi sponsor module appears above the footer on Graphics pages in the same placement using the same tag as Topic pages.

> **IMPORTANT!** Make sure ads are only used on dotcom pages, never on embeds.

```svelte
<!-- App.svelte -->
<script>
import { DianomiAd } from '@reuters-graphics/graphics-components';

export let embedded = false;
</script>

<!-- Check if in an embed context! -->
{#if !embedded}
<DianomiAd />
{/if}
```
1 change: 1 addition & 0 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export { default as Theme, themes } from './components/Theme/Theme.svelte';
export { default as ToolsHeader } from './components/ToolsHeader/ToolsHeader.svelte';
export { default as Video } from './components/Video/Video.svelte';
export { default as Visible } from './components/Visible/Visible.svelte';
export { default as DianomiAd } from './components/Dianomi/DianomiAd.svelte';

// Utilities
export { getEndNotesPropsFromDoc } from './components/EndNotes/docProps.js';
Expand Down