Skip to content

Conversation

@AhmedLukmanTR
Copy link
Collaborator

What's in this pull request

This PR implements the Dianomi ad which ensures that the Dianomi content displays in the div container after the necessary script has loaded.

Before submitting, please check that you've ...

  • Read our contributing guide
  • Documented any new components or features
  • Tagged an editor to review this PR

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 8d48bec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OffTop1
Copy link
Collaborator

OffTop1 commented Oct 22, 2024

Can you add a story to this component?

});
</script>

<div class="dianomi_context" data-dianomi-context-id="1948"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this display any visual content? If so, how does that interplay with our existing ad components?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does display the Dianomi sponsorship ads. Please expound on what you meant by interplaying with the existing ad components.

@AhmedLukmanTR AhmedLukmanTR changed the title feat: Implement Dianomi Sponsor Module AB#668532 feat: Implement Dianomi Sponsor Module Oct 29, 2024
@AhmedLukmanTR AhmedLukmanTR changed the title AB#668532 feat: Implement Dianomi Sponsor Module AB#668532 - feat: Implement Dianomi Sponsor Module Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants