-
Notifications
You must be signed in to change notification settings - Fork 7
AB#668532 - feat: Implement Dianomi Sponsor Module #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Can you add a story to this component? |
| }); | ||
| </script> | ||
|
|
||
| <div class="dianomi_context" data-dianomi-context-id="1948"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this display any visual content? If so, how does that interplay with our existing ad components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does display the Dianomi sponsorship ads. Please expound on what you meant by interplaying with the existing ad components.
What's in this pull request
This PR implements the Dianomi ad which ensures that the Dianomi content displays in the div container after the necessary script has loaded.
Before submitting, please check that you've ...