feat(telemetry): instrument Agent Mode run lifecycle#330
Open
cameroncooke wants to merge 1 commit into
Open
Conversation
This was referenced Jun 29, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cameroncooke
force-pushed
the
cameroncooke/sentry-08-agent-run-telemetry
branch
from
b31d2e2 to
e3b9139
Compare
cameroncooke
force-pushed
the
cameroncooke/sentry-07-workspace-action-telemetry
branch
from
ac072a1 to
78d8914
Compare
cameroncooke
force-pushed
the
cameroncooke/sentry-07-workspace-action-telemetry
branch
from
78d8914 to
ad68ae6
Compare
cameroncooke
force-pushed
the
cameroncooke/sentry-08-agent-run-telemetry
branch
from
e3b9139 to
000cdcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instruments the Agent Mode run lifecycle — the richest telemetry surface.
Stack: 8/10 · depends on PR 2 · Refs GH-183
What this changes
AgentRunSentryTelemetry.swift(new,@MainActor) — tracks a run start → terminal:agent.run.started/completed/failed/cancelled,agent.run.session.startscounter,agent.run.activegauge (1/0),agent.run.durationdistribution (coarse wall-clock),agent.provider.first_eventspan,ApprovalKind/ApprovalOutcome).AgentModeViewModel(.swift + InteractionActions/TabSession/WorktreeMerge),AgentModeRunService.swift,AgentRunTerminalCommitBarrier.swift— call sites at the lifecycle points.Business rules
ModelFamily, provider asProviderKind(closed enums — raw model/provider strings never escape).message_role+ counts only — never message text or transcript.activeAgentRunStartedAt.Key decisions
@MainActorbecause it reads view-model session state.#if; non-Voidhelpers live entirely inside one#ifblock so default builds compile them out cleanly.Note on size
~575 LOC; the bulk is the 417-line
AgentRunSentryTelemetry.swift, a single indivisible new file.Test plan