build(telemetry): link Sentry conditionally and document privacy model#323
Merged
Merged
Conversation
This was referenced Jun 29, 2026
Collaborator
Author
Add an opt-in REPOPROMPT_ENABLE_SENTRY build gate that links sentry-cocoa and defines REPOPROMPT_SENTRY_ENABLED, register the sentry-cocoa license, add the DSN Info.plist slot, and document the telemetry privacy model. Refs GH-183
d17e5a0 to
531da8a
Compare
provencher
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Establishes the opt-in build gate for Sentry telemetry and the privacy documentation. Adds no runtime behavior on its own — it only makes telemetry possible to compile in, and inert by default.
Stack: 1/10 · base
main· Refs GH-183What this changes
Package.swift: readsREPOPROMPT_ENABLE_SENTRYat manifest-eval time; only when=1does it add thesentry-cocoadependency and defineREPOPROMPT_SENTRY_ENABLED. Pinssentry-cocoa9.17.1(Package.resolved).AppBundle/Info.plist.template: adds an emptyRepoPromptSentryDSNslot.ThirdPartyLicenses/*+swiftpm_notice_guardrails.sh: registers sentry-cocoa's MIT license so the notice guardrail passes.docs/privacy/telemetry.md: the human-readable privacy contract.Business rules
#if REPOPROMPT_SENTRY_ENABLEDblocks in later PRs compile to nothing.REPOPROMPT_ENABLE_SENTRY=1.Key decisions
if sentryEnabled { … }block is the single, auditable opt-in point.Test plan
swift build(no flag) resolves and builds with the SDK absent.REPOPROMPT_ENABLE_SENTRY=1 swift buildlinks sentry-cocoa from cache. ✅ verified (rc=0).