rpk: Wire Grafana dashboard generation to Github #9662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now rpk will try to download the dashboards from our Observability repo, if something fails, then it will fallback to the old way of generating the dashboard
|
@r-vasquez - should rpk have a 'default' string in case github is unreachable. i.e.: just as part of rpk |
|
given that we have /public_metrics endpoint, and that's now stable, i think a static string could be fine too as a fallback. |
|
i guess caveat is that if rpk is old then .... so maybe w/ an additional flag |
|
@emaxerrno I'm working on a new PR that will include default embedded static files for each dashboard in the case that GH query fails (or if it's an air-gapped environment). I'll add a new flag to this PR to skip the download and go straight to the auto-generated dashboard. |
in the case of GH unreachable or that you just want the old autogenerated dashaboard then you can use this flag.
gene-redpanda
previously approved these changes
Mar 27, 2023
twmb
reviewed
Mar 27, 2023
And also have autocompletion for the --dashboard flag.
|
Last commit includes the autocompletion for the
|
gene-redpanda
approved these changes
Mar 27, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now rpk will try to download the dashboards from our Observability repo, if something fails, then it will fall back to the old way of generating the dashboard.
This is the first step towards solving #6502, next step is to fall back to embedded static files.
The user can use the bash auto-completion features ([shift] [shift]) to get the available dashboards, or use the
--dashboard helpoption:Backports Required
Release Notes
Features