Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: add interactive flag to generate grafana-dashboard #10213

Closed
wants to merge 1 commit into from

Conversation

r-vasquez
Copy link
Contributor

Fixes #9485

Example:

$ rpk generate grafana-dashboard --interactive

image

Backports Required

  • none - issue does not exist in previous branches

No release notes since this is a new feature and the release notes will be in #9662

Release Notes

  • none

@twmb
Copy link
Contributor

twmb commented Apr 20, 2023

Can we default to interactive if no flag is used, rather than requiring an --interactive flag?

@r-vasquez
Copy link
Contributor Author

That would be a similar behavior to the log-level change command, however, here it will break users that expect an output when running rpk generate grafana-dashboard without a --dashboard flag.

Also, the current --dashboard flag defaults to a specific dashboard so they will get the operations dashboard if no flags are provided.

@r-vasquez
Copy link
Contributor Author

Won't do. --interactive is not discoverable enough and does not bring additional value to the command space.

@r-vasquez r-vasquez closed this Apr 20, 2023
@r-vasquez r-vasquez deleted the grafana-interactive branch June 9, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpk: Interactive mode to download Grafana Dashboards
3 participants