-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: renaming Create
to Self-service
#2574
Changes from 3 commits
0e1e1c7
17354ea
99a4164
47d9406
712b71c
191eeae
2a13182
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ import extractDynamicConfig, { | |
DynamicRoute, | ||
} from '../../utils/dynamicUI/extractDynamicConfig'; | ||
import initializeRemotePlugins from '../../utils/dynamicUI/initializeRemotePlugins'; | ||
import { catalogTranslations } from '../catalog/catalog-translations/catalog'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please rename the folder This is aligned with https://backstage.io/docs/plugins/internationalization/#for-an-application-developer-overwrite-plugin-messages There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still open! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolved |
||
import { MenuIcon } from '../Root/MenuIcon'; | ||
import CommonIcons from './CommonIcons'; | ||
import defaultAppComponents from './defaultAppComponents'; | ||
|
@@ -458,6 +459,10 @@ export const DynamicRoot = ({ | |
api => !remoteApis.some(remoteApi => remoteApi.api.id === api.api.id), | ||
); | ||
app.current = createApp({ | ||
__experimentalTranslations: { | ||
availableLanguages: ['en'], | ||
resources: [catalogTranslations], | ||
}, | ||
apis: [...filteredStaticApis, ...remoteApis], | ||
bindRoutes({ bind }) { | ||
bindAppRoutes(bind, resolvedRouteBindingTargets, routeBindings); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { createTranslationMessages } from '@backstage/core-plugin-api/alpha'; | ||
import { catalogTranslationRef } from '@backstage/plugin-catalog/alpha'; | ||
|
||
const en = createTranslationMessages({ | ||
ref: catalogTranslationRef, | ||
full: false, // False means that this is a partial translation | ||
messages: { | ||
'indexPage.createButtonTitle': 'Self-service', | ||
}, | ||
}); | ||
|
||
export default en; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { createTranslationResource } from '@backstage/core-plugin-api/alpha'; | ||
import { catalogTranslationRef } from '@backstage/plugin-catalog/alpha'; | ||
|
||
export const catalogTranslations = createTranslationResource({ | ||
ref: catalogTranslationRef, | ||
translations: { | ||
en: () => import('./catalog-en'), | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one Self-service is enough here. Please remove one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved