feat: renaming Create to Self-service
#2574
Conversation
Signed-off-by: its-mitesh-kumar <[email protected]>
its-mitesh-kumar
changed the title
its-mitesh-kumar
changed the title
Create to Self-service
|
The image is available at: |
Signed-off-by: its-mitesh-kumar <[email protected]>
|
The image is available at: |
| @@ -20,6 +20,7 @@ import extractDynamicConfig, { | |||
| DynamicRoute, | |||
| } from '../../utils/dynamicUI/extractDynamicConfig'; | |||
| import initializeRemotePlugins from '../../utils/dynamicUI/initializeRemotePlugins'; | |||
| import { catalogTranslations } from '../catalog/catalog-translations/catalog'; | |||
There was a problem hiding this comment.
Please rename the folder
packages/app/src/components/catalog/catalog-translations
to
packages/app/src/components/catalog/translations
This is aligned with https://backstage.io/docs/plugins/internationalization/#for-an-application-developer-overwrite-plugin-messages
Signed-off-by: its-mitesh-kumar <[email protected]>
|
The image is available at: |
There was a problem hiding this comment.
2 small things. And can you please update the global-header plugin here as well to include your PR redhat-developer/rhdh-plugins#495
| | "Settings" | ||
| | "My Group" | ||
| | "Home" | ||
| | "Create..." | ||
| | "Self-service" |
There was a problem hiding this comment.
I think one Self-service is enough here. Please remove one.
| @@ -20,6 +20,7 @@ import extractDynamicConfig, { | |||
| DynamicRoute, | |||
| } from '../../utils/dynamicUI/extractDynamicConfig'; | |||
| import initializeRemotePlugins from '../../utils/dynamicUI/initializeRemotePlugins'; | |||
| import { catalogTranslations } from '../catalog/catalog-translations/catalog'; | |||
|
The image is available at: |
|
/retest-required |
Signed-off-by: its-mitesh-kumar <[email protected]>
|
The image is available at: |
Signed-off-by: its-mitesh-kumar <[email protected]>
|
The image is available at: |
Signed-off-by: its-mitesh-kumar <[email protected]>
|
The image is available at: |
|
/retest-required |
|
@christoph-jerolimov , I have updated e2e as well as addressed your comments . |
|
verified this on a cluster 
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c742d93
into
redhat-developer:main
Fixing : Rename the 'Create' that appears on the Global header
Screen Recording
Screen.Recording.2025-03-13.at.10.25.54.PM.mov