Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): reinstall @backstage/plugin-api-docs to fix node-gyp errors in tree-sitter #2547

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

BethGriggs
Copy link
Contributor

@BethGriggs BethGriggs commented Mar 12, 2025

Regenerated yarn.lock by running:

  • yarn install
  • cd packages/app
  • yarn remove @backstage/plugin-api-docs
  • yarn add @backstage/[email protected] (same version reinstalled)

This picked up transitive dependency updates that resolve node-gyp build errors in tree-sitter

Refs: https://issues.redhat.com/browse/RHIDP-6288

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing

How to test changes / Special notes to the reviewer

Copy link
Contributor

Copy link
Contributor

@BethGriggs
Copy link
Contributor Author

Rebased as yarn.lock changed on main a lot and had conflicts

@BethGriggs
Copy link
Contributor Author

This should clean up 1 of the 2 causes of node-gyp errors in building optional dependencies. The cpu-features will need another adjustment.

➤ YN0007: │ tree-sitter@npm:0.22.1 must be built because it never has been before or the last one failed
➤ YN0009: │ cpu-features@npm:0.0.9 couldn't be built successfully (exit code 1, logs can be found here: /private/var/folders/9g/93qrln9j5yq3396zcjzsghf00000gn/T/xfs-8889b695/build.log)
➤ YN0007: │ ssh2@npm:1.15.0 must be built because it never has been before or the last one failed
➤ YN0007: │ tree-sitter-json@npm:0.24.8 [44844] must be built because it never has been before or the last one failed
➤ YN0007: │ @tree-sitter-grammars/tree-sitter-yaml@npm:0.7.0 [bb3b7] must be built because it never has been before or the last one failed
➤ YN0000: └ Completed in 10s 139ms
➤ YN0000: Done with warnings in 11s 427ms

Copy link
Contributor

Copy link
Collaborator

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a7a8386 into redhat-developer:main Mar 21, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants