fix(build): adjust native dependencies for node 22 #2607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gashcrumb
changed the title
gashcrumb
force-pushed
the
adjust-deps-cachi2-node23
branch
from
aac7afd to
793acf0
Compare
|
The image is available at: |
schultzp2020
requested changes
Mar 20, 2025
3 tasks
This change regenerates enough of the yarn.lock to adjust a few native dependency package versions so the project installs properly with node 22 and can still be built offline. This change also brings in a fix to the @janus-idp/cli package so that it handles manually added resolutions as expected. Signed-off-by: Stan Lewis <[email protected]>
gashcrumb
force-pushed
the
adjust-deps-cachi2-node23
branch
from
793acf0 to
f54ac6b
Compare
|
The image is available at: |
|
As regenerating the yarn.lock should sort this problem without the extra resolutions, the CLI update isn't necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change regenerates enough of the yarn.lock to adjust a few native dependency package versions to ensure the project installs properly with node 22 and can still be built offline. This fix also required bringing in a fix to the @janus-idp/cli package so that it handles manually added resolutions as expected.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer