Skip to content

Add missing RDK_LOG_FATAL definition to fallback logger implementations #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: feature/rfclog
Choose a base branch
from
Draft

Add missing RDK_LOG_FATAL definition to fallback logger implementations #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84e29bc
Initial plan
Copilot Feb 12, 2026
77aa236
Add RDK_LOG_FATAL definition to fallback log levels
Copilot Feb 12, 2026
46ce54e
Add RDK_LOG_FATAL to mock rdk_debug.h for test consistency
Copilot Feb 12, 2026
25beb87
Final status update
Copilot Feb 12, 2026
9513380
Add .gitignore and remove build artifacts
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Autotools generated files
Makefile.in
/aclocal.m4
/autom4te.cache/
/compile
/config.guess
/config.log
/config.status
/config.sub
/configure
/depcomp
/install-sh
/libtool
/ltmain.sh
/missing
**/config.h.in
**/Makefile.in

# Build artifacts
*.o
*.lo
*.la
.libs/
.deps/
*.gcda
*.gcno
*.gcov
coverage.info
filtered.info
rfc_coverage.info

# CodeQL
_codeql_detected_source_root
4 changes: 4 additions & 0 deletions rfcMgr/gtest/mocks/rdk_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#define RDK_LOG_INFO 3
#define RDK_LOG_WARN 4
#define RDK_LOG_ERROR 5
#define RDK_LOG_FATAL 6

#define rdk_logger_init(DEBUG_INI_NAME) ;

Expand All @@ -45,6 +46,9 @@
else if (( level == RDK_LOG_ERROR )) { \
printf("ERROR: %s: ", module); \
} \
else if (( level == RDK_LOG_FATAL )) { \
printf("FATAL: %s: ", module); \
} \
printf(__VA_ARGS__); \
} while (0)

Expand Down
21 changes: 20 additions & 1 deletion rfcMgr/rdk_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
#define RDK_LOG_INFO 3
#define RDK_LOG_WARN 4
#define RDK_LOG_ERROR 5
#define RDK_LOG_FATAL 6

// RDK Logger success/failure codes
#define RDK_SUCCESS 0
Expand Down Expand Up @@ -88,6 +89,9 @@
else if (level == RDK_LOG_ERROR) { \
printf("ERROR: %s: ", module); \
} \
else if (level == RDK_LOG_FATAL) { \
printf("FATAL: %s: ", module); \
} \
printf(__VA_ARGS__); \
} while (0)
#endif
Expand All @@ -98,6 +102,7 @@
#define RDK_LOG_INFO 3
#define RDK_LOG_WARN 4
#define RDK_LOG_ERROR 5
#define RDK_LOG_FATAL 6

#define RDK_SUCCESS 0
#define RDK_FAILURE -1
Expand All @@ -120,7 +125,21 @@
// Simple printf-based logging when RDK_LOGGER is not enabled
#define RDK_LOG(level, module, ...) \
do { \
printf("[%s] ", module); \
if (level == RDK_LOG_DEBUG) { \
printf("DEBUG: %s: ", module); \
} \
else if (level == RDK_LOG_INFO) { \
printf("INFO: %s: ", module); \
} \
else if (level == RDK_LOG_ERROR) { \
printf("ERROR: %s: ", module); \
} \
else if (level == RDK_LOG_FATAL) { \
printf("FATAL: %s: ", module); \
} \
else { \
printf("[%s] ", module); \
} \
printf(__VA_ARGS__); \
} while (0)
#endif
Expand Down