Skip to content

Add missing RDK_LOG_FATAL definition to fallback logger implementations#176

Draft
Copilot wants to merge 5 commits intofeature/rfclogfrom
copilot/sub-pr-175
Draft

Add missing RDK_LOG_FATAL definition to fallback logger implementations#176
Copilot wants to merge 5 commits intofeature/rfclogfrom
copilot/sub-pr-175

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

The RDK_LOG_FATAL log level was referenced in rdkv_cdl_log_wrapper.h but undefined in fallback implementations, causing compilation failures when the real RDK logger isn't available.

Changes

  • Added RDK_LOG_FATAL (value 6) to fallback log level definitions in both RDK_LOGGER conditional branches
  • Updated RDK_LOG macros to handle FATAL level with appropriate prefix formatting
  • Added definition to test mock for consistency

Files Modified

  • rfcMgr/rdk_debug.h - Main fallback implementations
  • rfcMgr/gtest/mocks/rdk_debug.h - Test mock
// Before: Missing FATAL level
#define RDK_LOG_ERROR 5
// After: Complete log level definitions
#define RDK_LOG_ERROR 5
#define RDK_LOG_FATAL 6

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 4 commits February 12, 2026 20:15
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Copilot AI changed the title [WIP] Add changes based on feedback from pull request #175 Add missing RDK_LOG_FATAL definition to fallback logger implementations Feb 12, 2026
Copilot AI requested a review from nhanasi February 12, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants