Add missing RDK_LOG_FATAL definition to fallback logger implementations#176
Draft
Copilot wants to merge 5 commits intofeature/rfclogfrom
Draft
Add missing RDK_LOG_FATAL definition to fallback logger implementations#176Copilot wants to merge 5 commits intofeature/rfclogfrom
Copilot wants to merge 5 commits intofeature/rfclogfrom
Conversation
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add changes based on feedback from pull request #175
Add missing RDK_LOG_FATAL definition to fallback logger implementations
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RDK_LOG_FATALlog level was referenced inrdkv_cdl_log_wrapper.hbut undefined in fallback implementations, causing compilation failures when the real RDK logger isn't available.Changes
RDK_LOG_FATAL(value 6) to fallback log level definitions in both RDK_LOGGER conditional branchesRDK_LOGmacros to handle FATAL level with appropriate prefix formattingFiles Modified
rfcMgr/rdk_debug.h- Main fallback implementationsrfcMgr/gtest/mocks/rdk_debug.h- Test mock💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.