Skip to content

Merge #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Vismalskumar0 wants to merge 23 commits into from
Closed

Merge #171

Changes from 4 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7f37e75
Update rfc_manager.cpp
nhanasi Feb 5, 2026
f584523
Update rfc_manager.cpp
nhanasi Feb 5, 2026
acb6cfe
Update rfc_manager.cpp
nhanasi Feb 6, 2026
904a916
Merge pull request #166 from rdkcentral/feature/rfclog
nhanasi Feb 6, 2026
0d2d9c0
Merge pull request #174 from rdkcentral/develop
nhanasi Feb 12, 2026
9fae7ea
Create rdk_debug.h
nhanasi Feb 12, 2026
b8758d4
Update rfc_manager.cpp
nhanasi Feb 12, 2026
8b0a25a
Apply suggestion from @Copilot
nhanasi Feb 12, 2026
ed665ce
Initial plan
Copilot Feb 12, 2026
8963bce
Add RDK_LOG_FATAL definition to fallback log levels
Copilot Feb 12, 2026
efcabe1
Final verification complete
Copilot Feb 12, 2026
c093093
Add .gitignore and remove build artifacts
Copilot Feb 12, 2026
faa6b7b
Merge pull request #177 from rdkcentral/copilot/sub-pr-175-again
nhanasi Feb 12, 2026
e3be91c
Apply suggestion from @Copilot
nhanasi Feb 12, 2026
3dcde8e
Apply suggestion from @Copilot
nhanasi Feb 12, 2026
1e8d64d
Update run_l2.sh
nhanasi Feb 12, 2026
22c7e07
Delete .gitignore
nhanasi Feb 12, 2026
b63bb70
Update run_l2.sh
nhanasi Feb 12, 2026
ed35f15
Update rfc_manager.cpp
nhanasi Feb 13, 2026
f790109
RDKEMW-13945 Fix L2 Issue on RFC Component
Feb 16, 2026
f329d0a
Merge pull request #175 from rdkcentral/feature/rfclog
nhanasi Feb 16, 2026
5e13181
Merge branch 'develop' into feature/RDKEMW-13945
madhubabutt Feb 16, 2026
359fc04
Merge pull request #178 from rdkcentral/feature/RDKEMW-13945
nhanasi Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions rfcMgr/rfc_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
#include "rfc_common.h"
#include "rfc_mgr_iarm.h"
#include "rfc_xconf_handler.h"
#if defined(RDK_LOGGER)
#include "rdk_logger.h"
#endif
#include <fstream>
#include <unistd.h>
#include <sys/types.h>
Expand All @@ -39,9 +42,21 @@ namespace rfc {
}
#endif
RFCManager ::RFCManager() {
#if defined(RDK_LOGGER)
/* Initialize RDK Logger */
rdk_logger_init(0 == access(OVERIDE_DEBUG_INI_FILE, R_OK) ? OVERIDE_DEBUG_INI_FILE : DEBUG_INI_FILE);

static char RFCMGRLOG[] = "LOG.RDK.RFCMGR";
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static char RFCMGRLOG[] = "LOG.RDK.RFCMGR"; is not modified anywhere and can be static const char* (or constexpr const char[]) to avoid exposing a writable buffer unnecessarily.

Suggested change
static char RFCMGRLOG[] = "LOG.RDK.RFCMGR";
static constexpr char RFCMGRLOG[] = "LOG.RDK.RFCMGR";

Copilot uses AI. Check for mistakes.
rdk_logger_ext_config_t config = {
.pModuleName = RFCMGRLOG, /* Module name */
.loglevel = RDK_LOG_INFO, /* Default log level */
.output = RDKLOG_OUTPUT_CONSOLE, /* Output to console (stdout/stderr) */
.format = RDKLOG_FORMAT_WITH_TS, /* Timestamped format */
.pFilePolicy = NULL /* Not using file output, so NULL */
};
Comment on lines +48 to +54
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rdk_logger_ext_config_t config = { .pModuleName = ..., ... } uses C++ designated initializers. This component is built with -std=c++17 and -Werror (see rfcMgr/Makefile.am), so this will not compile on standard-conforming C++17 toolchains. Initialize config without designators (or default-construct then assign fields) to keep the build C++17-compatible.

Suggested change
rdk_logger_ext_config_t config = {
.pModuleName = RFCMGRLOG, /* Module name */
.loglevel = RDK_LOG_INFO, /* Default log level */
.output = RDKLOG_OUTPUT_CONSOLE, /* Output to console (stdout/stderr) */
.format = RDKLOG_FORMAT_WITH_TS, /* Timestamped format */
.pFilePolicy = NULL /* Not using file output, so NULL */
};
rdk_logger_ext_config_t config{};
config.pModuleName = RFCMGRLOG; /* Module name */
config.loglevel = RDK_LOG_INFO; /* Default log level */
config.output = RDKLOG_OUTPUT_CONSOLE; /* Output to console (stdout/stderr) */
config.format = RDKLOG_FORMAT_WITH_TS; /* Timestamped format */
config.pFilePolicy = NULL; /* Not using file output, so NULL */

Copilot uses AI. Check for mistakes.

if (rdk_logger_ext_init(&config) != RDK_SUCCESS) {
printf("RFC : ERROR - Extended logger init failed\n");
}
Comment on lines +56 to +58
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfcMgr_gtest builds rfc_manager.cpp but the gtest Makefile does not link -lrdkloggers. Introducing a direct call to rdk_logger_ext_init() is therefore likely to break unit-test linking (the symbol is not provided anywhere in this repo). Consider guarding this call under #if !defined(GTEST_ENABLE) and/or providing a test stub, or update the gtest target’s link flags accordingly.

Copilot uses AI. Check for mistakes.
#endif
/* Initialize IARM Bus */
InitializeIARM();
}
Expand Down