Merge

[Vismalskumar0]

No description provided.

[Copilot]

Pull request overview

Updates RFC Manager startup to initialize logging via RDK Logger’s “extended” configuration API (behind RDK_LOGGER), instead of the prior rdk_logger_init() call.

Changes:

• Add conditional include of rdk_logger.h when RDK_LOGGER is defined.
• Replace logger initialization in RFCManager::RFCManager() with rdk_logger_ext_init() using an explicit config struct.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

rfcMgr_gtest builds rfc_manager.cpp but the gtest Makefile does not link -lrdkloggers. Introducing a direct call to rdk_logger_ext_init() is therefore likely to break unit-test linking (the symbol is not provided anywhere in this repo). Consider guarding this call under #if !defined(GTEST_ENABLE) and/or providing a test stub, or update the gtest target’s link flags accordingly.

[Copilot]

static char RFCMGRLOG[] = "LOG.RDK.RFCMGR"; is not modified anywhere and can be static const char* (or constexpr const char[]) to avoid exposing a writable buffer unnecessarily.

Suggested change

	static char RFCMGRLOG[] = "LOG.RDK.RFCMGR";
	static constexpr char RFCMGRLOG[] = "LOG.RDK.RFCMGR";

[Copilot]

rdk_logger_ext_config_t config = { .pModuleName = ..., ... } uses C++ designated initializers. This component is built with -std=c++17 and -Werror (see rfcMgr/Makefile.am), so this will not compile on standard-conforming C++17 toolchains. Initialize config without designators (or default-construct then assign fields) to keep the build C++17-compatible.

Suggested change

	rdk_logger_ext_config_t config = {
	.pModuleName = RFCMGRLOG, /* Module name */
	.loglevel = RDK_LOG_INFO, /* Default log level */
	.output = RDKLOG_OUTPUT_CONSOLE, /* Output to console (stdout/stderr) */
	.format = RDKLOG_FORMAT_WITH_TS, /* Timestamped format */
	.pFilePolicy = NULL /* Not using file output, so NULL */
	};
	rdk_logger_ext_config_t config{};
	config.pModuleName = RFCMGRLOG; /* Module name */
	config.loglevel = RDK_LOG_INFO; /* Default log level */
	config.output = RDKLOG_OUTPUT_CONSOLE; /* Output to console (stdout/stderr) */
	config.format = RDKLOG_FORMAT_WITH_TS; /* Timestamped format */
	config.pFilePolicy = NULL; /* Not using file output, so NULL */

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

2 out of 3 committers have signed the CLA.
✅ (nhanasi)[https://github.com/nhanasi]
✅ (madhubabutt)[https://github.com/madhubabutt]
❌ @Copilot
_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}