Skip to content

RDKB-62979 RDKB-62980 : Update native build #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nithishkumar-T wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RDKB-62979 RDKB-62980 : Update native build #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1171b45
Update native build
Nithishkumar-T Feb 10, 2026
d9638d1
Update README.md
Nithishkumar-T Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/native-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,18 @@ jobs:

- name: native build
run: |
chmod +x cov_docker_script/run_setup_dependencies.sh
./cov_docker_script/run_setup_dependencies.sh
chmod +x cov_docker_script/run_native_build.sh
./cov_docker_script/run_native_build.sh
# Trust the workspace
git config --global --add safe.directory '*'
Comment on lines +22 to +23
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting safe.directory to '*' trusts every directory globally for Git operations on the runner, which is broader than necessary. Prefer trusting only the checked-out workspace path (e.g., $GITHUB_WORKSPACE / $(pwd)) to reduce exposure while still addressing the ownership/safe-directory issue.

Suggested change
# Trust the workspace
git config --global --add safe.directory '*'
# Trust only the current workspace directory
git config --global --add safe.directory "$PWD"

Copilot uses AI. Check for mistakes.

# Pull the latest changes for the native build system
git submodule update --init --recursive --remote
Comment on lines +25 to +26
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --remote makes CI builds non-reproducible because it updates the submodule to the latest commit on the tracked branch at build time (instead of the commit pinned in the superproject). Consider removing --remote and relying on the submodule commit recorded in the repo; if you intentionally want floating builds, at least log the resulting submodule commit (git submodule status / git -C build_tools_workflows rev-parse HEAD) for traceability.

Suggested change
# Pull the latest changes for the native build system
git submodule update --init --recursive --remote
# Pull the latest changes for the native build system (use pinned submodule commits)
git submodule update --init --recursive

Copilot uses AI. Check for mistakes.

# Build and install dependencies
chmod +x build_tools_workflows/cov_docker_script/setup_dependencies.sh
./build_tools_workflows/cov_docker_script/setup_dependencies.sh ./cov_docker_script/component_config.json

# Build component
chmod +x build_tools_workflows/cov_docker_script/build_native.sh
./build_tools_workflows/cov_docker_script/build_native.sh ./cov_docker_script/component_config.json "$(pwd)"
env:
GITHUB_TOKEN: ${{ secrets.RDKCM_RDKE }}
4 changes: 4 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[submodule "build_tools_workflows"]
path = build_tools_workflows
url = https://github.com/rdkcentral/build_tools_workflows
branch = develop
1 change: 1 addition & 0 deletions build_tools_workflows
Open in desktop
Submodule build_tools_workflows added at b7c962
Loading