Skip to content

Comments

RDKB-62979 RDKB-62980 : Update native build#25

Open
Nithishkumar-T wants to merge 2 commits intodevelopfrom
feature/native_build_update
Open

RDKB-62979 RDKB-62980 : Update native build#25
Nithishkumar-T wants to merge 2 commits intodevelopfrom
feature/native_build_update

Conversation

@Nithishkumar-T
Copy link

@Nithishkumar-T Nithishkumar-T commented Feb 10, 2026

Reason for change: Enable coverity scan using native build.
Test Procedure: All the checks should pass in github
Risks: Low
Priority: P1
Signed-off-by: [email protected]

Copilot AI review requested due to automatic review settings February 10, 2026 09:11
@Nithishkumar-T Nithishkumar-T requested review from a team as code owners February 10, 2026 09:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the native build pipeline to use build_tools_workflows as a Git submodule and invoke its build scripts directly (removing local wrapper scripts).

Changes:

  • Replace wrapper scripts with direct calls into the build_tools_workflows submodule.
  • Add build_tools_workflows as a Git submodule (tracking develop) and update CI to initialize/update it.
  • Update component_config.json to reference the external build script from the submodule.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cov_docker_script/run_setup_dependencies.sh Removed local dependency-setup wrapper script in favor of submodule scripts.
cov_docker_script/run_native_build.sh Removed local native-build wrapper script in favor of submodule scripts.
cov_docker_script/run_external_build.sh Removed local external-build wrapper script in favor of submodule scripts.
cov_docker_script/component_config.json Points external build to build_tools_workflows script path.
build_tools_workflows Adds/updates the submodule pointer commit.
.gitmodules Registers build_tools_workflows submodule and branch tracking.
.github/workflows/native-build.yml Updates CI to init/update submodule and run submodule scripts directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +22 to +23
# Trust the workspace
git config --global --add safe.directory '*'
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting safe.directory to '*' trusts every directory globally for Git operations on the runner, which is broader than necessary. Prefer trusting only the checked-out workspace path (e.g., $GITHUB_WORKSPACE / $(pwd)) to reduce exposure while still addressing the ownership/safe-directory issue.

Suggested change
# Trust the workspace
git config --global --add safe.directory '*'
# Trust only the current workspace directory
git config --global --add safe.directory "$PWD"

Copilot uses AI. Check for mistakes.
Comment on lines +25 to +26
# Pull the latest changes for the native build system
git submodule update --init --recursive --remote
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --remote makes CI builds non-reproducible because it updates the submodule to the latest commit on the tracked branch at build time (instead of the commit pinned in the superproject). Consider removing --remote and relying on the submodule commit recorded in the repo; if you intentionally want floating builds, at least log the resulting submodule commit (git submodule status / git -C build_tools_workflows rev-parse HEAD) for traceability.

Suggested change
# Pull the latest changes for the native build system
git submodule update --init --recursive --remote
# Pull the latest changes for the native build system (use pinned submodule commits)
git submodule update --init --recursive

Copilot uses AI. Check for mistakes.
@Nithishkumar-T Nithishkumar-T changed the title RDKB-62980 : Update native build RDKB-62979 RDKB-62980 : Update native build Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant