RDKB-62979 RDKB-62980 : Update native build#25
RDKB-62979 RDKB-62980 : Update native build#25Nithishkumar-T wants to merge 2 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the native build pipeline to use build_tools_workflows as a Git submodule and invoke its build scripts directly (removing local wrapper scripts).
Changes:
- Replace wrapper scripts with direct calls into the
build_tools_workflowssubmodule. - Add
build_tools_workflowsas a Git submodule (trackingdevelop) and update CI to initialize/update it. - Update
component_config.jsonto reference the external build script from the submodule.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cov_docker_script/run_setup_dependencies.sh | Removed local dependency-setup wrapper script in favor of submodule scripts. |
| cov_docker_script/run_native_build.sh | Removed local native-build wrapper script in favor of submodule scripts. |
| cov_docker_script/run_external_build.sh | Removed local external-build wrapper script in favor of submodule scripts. |
| cov_docker_script/component_config.json | Points external build to build_tools_workflows script path. |
| build_tools_workflows | Adds/updates the submodule pointer commit. |
| .gitmodules | Registers build_tools_workflows submodule and branch tracking. |
| .github/workflows/native-build.yml | Updates CI to init/update submodule and run submodule scripts directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Trust the workspace | ||
| git config --global --add safe.directory '*' |
There was a problem hiding this comment.
Setting safe.directory to '*' trusts every directory globally for Git operations on the runner, which is broader than necessary. Prefer trusting only the checked-out workspace path (e.g., $GITHUB_WORKSPACE / $(pwd)) to reduce exposure while still addressing the ownership/safe-directory issue.
| # Trust the workspace | |
| git config --global --add safe.directory '*' | |
| # Trust only the current workspace directory | |
| git config --global --add safe.directory "$PWD" |
| # Pull the latest changes for the native build system | ||
| git submodule update --init --recursive --remote |
There was a problem hiding this comment.
Using --remote makes CI builds non-reproducible because it updates the submodule to the latest commit on the tracked branch at build time (instead of the commit pinned in the superproject). Consider removing --remote and relying on the submodule commit recorded in the repo; if you intentionally want floating builds, at least log the resulting submodule commit (git submodule status / git -C build_tools_workflows rev-parse HEAD) for traceability.
| # Pull the latest changes for the native build system | |
| git submodule update --init --recursive --remote | |
| # Pull the latest changes for the native build system (use pinned submodule commits) | |
| git submodule update --init --recursive |
Reason for change: Enable coverity scan using native build.
Test Procedure: All the checks should pass in github
Risks: Low
Priority: P1
Signed-off-by: [email protected]