Skip to content

RDKEMW-12197: Integrate entservices-remotecontrol and entservices-voicecontrol to MW builds #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msmith113 wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-12197: Integrate entservices-remotecontrol and entservices-voicecontrol to MW builds #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a3f1b4
Removing voice and remote control plugins.
msmith113 Feb 12, 2026
6310ed6
Merge branch 'develop' into feature/RDKEMW-12197
msmith113 Feb 18, 2026
05470c8
Adding temp dummy target when there are no cmake install targets
msmith113 Feb 18, 2026
2c8d9f6
Updates
msmith113 Feb 18, 2026
f9c3b2e
Merge from upstream develop branch and removed RemoteControl and Voic…
msmith113 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,16 @@ if(RDK_SERVICES_L1_TEST)
add_subdirectory(Tests/L1Tests)
endif()

if(PLUGIN_VOICECONTROL)
add_subdirectory(VoiceControl)
endif()

if(PLUGIN_REMOTECONTROL)
add_subdirectory(RemoteControl)
endif()



if(PLUGIN_MOTION_DETECTION)
add_subdirectory(MotionDetection)
endif()
Comment on lines 44 to 46
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description indicate integrating VoiceControl/RemoteControl into MW builds, but this CMakeLists change only removes both plugins from the build (no replacement integration such as FetchContent/ExternalProject/add_subdirectory to new sources). This looks like either a missing part of the integration or a mismatch with the PR intent—please either add the new build integration here (or in whatever MW build repo this PR targets) and reference it, or update the PR title/description to reflect that this PR is removing the in-repo implementations.

Copilot uses AI. Check for mistakes.

# Add a dummy install target to prevent cmake install failures when no plugins are enabled. This is needed temporarily while plugins are moved to other repos.
if(NOT RDK_SERVICES_L1_TEST AND NOT PLUGIN_MOTION_DETECTION)
install(CODE "message(STATUS \"entservices-peripherals: No install target available, ignoring...\")")
endif()

if(WPEFRAMEWORK_CREATE_IPKG_TARGETS)
set(CPACK_GENERATOR "DEB")
set(CPACK_DEB_COMPONENT_INSTALL ON)
Expand Down
12 changes: 0 additions & 12 deletions RemoteControl/CHANGELOG.md
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions RemoteControl/CMakeLists.txt
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions RemoteControl/Module.cpp
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions RemoteControl/Module.h
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions RemoteControl/README.md
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions RemoteControl/RemoteControl.conf.in
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions RemoteControl/RemoteControl.config
View file
Open in desktop

This file was deleted.

Loading
Loading