RDKEMW-12197: Integrate entservices-remotecontrol and entservices-voicecontrol to MW builds#134
RDKEMW-12197: Integrate entservices-remotecontrol and entservices-voicecontrol to MW builds#134
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the in-repo VoiceControl and RemoteControl Thunder plugin implementations (source, configs, docs, and test client) and drops their inclusion from the top-level build, presumably in preparation for consuming these services from the external entservices-voicecontrol and entservices-remotecontrol repos in MW builds.
Changes:
- Remove the
VoiceControl/plugin implementation and its configuration/documentation files. - Remove the
RemoteControl/plugin implementation and its test client/configuration/documentation files. - Update the root
CMakeLists.txtto stop buildingVoiceControlandRemoteControl.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
VoiceControl/VoiceControl.h |
Removes the VoiceControl plugin public header (plugin no longer built from this repo). |
VoiceControl/VoiceControl.cpp |
Removes the VoiceControl plugin implementation and JSON-RPC/IARM handling. |
VoiceControl/VoiceControl.config |
Removes VoiceControl build-time config metadata. |
VoiceControl/VoiceControl.conf.in |
Removes VoiceControl runtime config template. |
VoiceControl/README.md |
Removes VoiceControl build/test documentation. |
VoiceControl/Module.h |
Removes VoiceControl module definition header. |
VoiceControl/Module.cpp |
Removes VoiceControl module declaration unit. |
VoiceControl/CMakeLists.txt |
Removes VoiceControl plugin build target definition. |
VoiceControl/CHANGELOG.md |
Removes VoiceControl changelog file. |
RemoteControl/test/remoteControlTestClient.cpp |
Removes the RemoteControl C++ test client. |
RemoteControl/test/Module.h |
Removes the test client module header. |
RemoteControl/test/CMakeLists.txt |
Removes build/install rules for the test client. |
RemoteControl/RemoteControl.h |
Removes the RemoteControl plugin public header. |
RemoteControl/RemoteControl.cpp |
Removes the RemoteControl plugin implementation and JSON-RPC/IARM handling. |
RemoteControl/RemoteControl.config |
Removes RemoteControl build-time config metadata. |
RemoteControl/RemoteControl.conf.in |
Removes RemoteControl runtime config template. |
RemoteControl/README.md |
Removes RemoteControl build/test documentation. |
RemoteControl/Module.h |
Removes RemoteControl module definition header. |
RemoteControl/Module.cpp |
Removes RemoteControl module declaration unit. |
RemoteControl/CMakeLists.txt |
Removes RemoteControl plugin build target definition (and test subdir inclusion). |
RemoteControl/CHANGELOG.md |
Removes RemoteControl changelog file. |
CMakeLists.txt |
Removes add_subdirectory() entries for VoiceControl and RemoteControl. |
| if(PLUGIN_MOTION_DETECTION) | ||
| add_subdirectory(MotionDetection) | ||
| endif() |
There was a problem hiding this comment.
PR title/description indicate integrating VoiceControl/RemoteControl into MW builds, but this CMakeLists change only removes both plugins from the build (no replacement integration such as FetchContent/ExternalProject/add_subdirectory to new sources). This looks like either a missing part of the integration or a mismatch with the PR intent—please either add the new build integration here (or in whatever MW build repo this PR targets) and reference it, or update the PR title/description to reflect that this PR is removing the in-repo implementations.
…eControl plugins.
Removing
RemoteControlandVoiceControlplugins as they are in separate repos.https://ccp.sys.comcast.net/browse/RDKEMW-12197
https://ccp.sys.comcast.net/browse/RDKEMW-12797