Skip to content

RDKEMW-12197: Integrate entservices-remotecontrol and entservices-voicecontrol to MW builds#134

Open
msmith113 wants to merge 5 commits intodevelopfrom
feature/RDKEMW-12197
Open

RDKEMW-12197: Integrate entservices-remotecontrol and entservices-voicecontrol to MW builds#134
msmith113 wants to merge 5 commits intodevelopfrom
feature/RDKEMW-12197

Conversation

@msmith113
Copy link

@msmith113 msmith113 commented Feb 12, 2026

@msmith113 msmith113 requested a review from a team as a code owner February 12, 2026 14:44
Copilot AI review requested due to automatic review settings February 12, 2026 14:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the in-repo VoiceControl and RemoteControl Thunder plugin implementations (source, configs, docs, and test client) and drops their inclusion from the top-level build, presumably in preparation for consuming these services from the external entservices-voicecontrol and entservices-remotecontrol repos in MW builds.

Changes:

  • Remove the VoiceControl/ plugin implementation and its configuration/documentation files.
  • Remove the RemoteControl/ plugin implementation and its test client/configuration/documentation files.
  • Update the root CMakeLists.txt to stop building VoiceControl and RemoteControl.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
VoiceControl/VoiceControl.h Removes the VoiceControl plugin public header (plugin no longer built from this repo).
VoiceControl/VoiceControl.cpp Removes the VoiceControl plugin implementation and JSON-RPC/IARM handling.
VoiceControl/VoiceControl.config Removes VoiceControl build-time config metadata.
VoiceControl/VoiceControl.conf.in Removes VoiceControl runtime config template.
VoiceControl/README.md Removes VoiceControl build/test documentation.
VoiceControl/Module.h Removes VoiceControl module definition header.
VoiceControl/Module.cpp Removes VoiceControl module declaration unit.
VoiceControl/CMakeLists.txt Removes VoiceControl plugin build target definition.
VoiceControl/CHANGELOG.md Removes VoiceControl changelog file.
RemoteControl/test/remoteControlTestClient.cpp Removes the RemoteControl C++ test client.
RemoteControl/test/Module.h Removes the test client module header.
RemoteControl/test/CMakeLists.txt Removes build/install rules for the test client.
RemoteControl/RemoteControl.h Removes the RemoteControl plugin public header.
RemoteControl/RemoteControl.cpp Removes the RemoteControl plugin implementation and JSON-RPC/IARM handling.
RemoteControl/RemoteControl.config Removes RemoteControl build-time config metadata.
RemoteControl/RemoteControl.conf.in Removes RemoteControl runtime config template.
RemoteControl/README.md Removes RemoteControl build/test documentation.
RemoteControl/Module.h Removes RemoteControl module definition header.
RemoteControl/Module.cpp Removes RemoteControl module declaration unit.
RemoteControl/CMakeLists.txt Removes RemoteControl plugin build target definition (and test subdir inclusion).
RemoteControl/CHANGELOG.md Removes RemoteControl changelog file.
CMakeLists.txt Removes add_subdirectory() entries for VoiceControl and RemoteControl.

Comment on lines 47 to 49
if(PLUGIN_MOTION_DETECTION)
add_subdirectory(MotionDetection)
endif()
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description indicate integrating VoiceControl/RemoteControl into MW builds, but this CMakeLists change only removes both plugins from the build (no replacement integration such as FetchContent/ExternalProject/add_subdirectory to new sources). This looks like either a missing part of the integration or a mismatch with the PR intent—please either add the new build integration here (or in whatever MW build repo this PR targets) and reference it, or update the PR title/description to reflect that this PR is removing the in-repo implementations.

Copilot uses AI. Check for mistakes.
Copy link

@egalla204 egalla204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for test

Copilot AI review requested due to automatic review settings February 18, 2026 15:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

Copy link

@egalla204 egalla204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for QA verification

Copilot AI review requested due to automatic review settings February 23, 2026 16:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants