Skip to content

Add support for COMRPC changes in L2Tests plugin in Testframework repo #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smanes0213 wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add support for COMRPC changes in L2Tests plugin in Testframework repo #162

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7434937
Update L1 workflow to use L2TestPlugin_COMRPC branch for testframework
smanes0213 Jan 7, 2026
0b7158b
Change build type to develop for Thunder build process.
smanes0213 Jan 7, 2026
4c2bb46
Change entservices-apis checkout ref to Test branch
smanes0213 Jan 7, 2026
8cb10f7
Resolve issues causing L1 failures
smanes0213 Jan 7, 2026
3458b91
Update test_MiracastService.cpp
smanes0213 Jan 7, 2026
a303428
Update test_MiracastService.cpp
smanes0213 Jan 7, 2026
51900e3
Remove Deinitialize from test fixtures and let destructor handle the …
smanes0213 Jan 8, 2026
0557338
Remove Debug flag while building thunder
smanes0213 Jan 8, 2026
c814821
Merge branch 'develop' into L2TestPlugin_COMRPC
smanes0213 Jan 15, 2026
7860630
Update L1-tests.yml
mkumar705 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/L1-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: develop
ref: L2TestPlugin_COMRPC
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change hardcodes a feature branch reference instead of using the stable 'develop' branch. Feature branch references in workflow files can cause issues if the branch is deleted, renamed, or if changes are not coordinated across repositories. This appears to be a temporary change for testing purposes. Consider using environment variables or workflow inputs to make this configurable, or document in the PR when these references will be reverted to 'develop'.

Suggested change
ref: L2TestPlugin_COMRPC
ref: develop

Copilot uses AI. Check for mistakes.
token: ${{ secrets.RDKCM_RDKE }}

- name: Checkout entservices-casting
Expand All @@ -138,7 +138,7 @@ jobs:
with:
repository: rdkcentral/entservices-casting
path: entservices-casting
ref: develop
ref: L2TestPlugin_COMRPC
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change hardcodes a feature branch reference instead of using the stable 'develop' branch. Feature branch references in workflow files can cause issues if the branch is deleted, renamed, or if changes are not coordinated across repositories. This appears to be a temporary change for testing purposes. Consider using environment variables or workflow inputs to make this configurable, or document in the PR when these references will be reverted to 'develop'.

Copilot uses AI. Check for mistakes.

- name: Checkout googletest
if: steps.cache.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -203,7 +203,7 @@ jobs:
with:
repository: rdkcentral/entservices-apis
path: entservices-apis
ref: ${{env.INTERFACES_REF}}
ref: Test
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the environment variable reference '${{env.INTERFACES_REF}}' (which resolves to 'develop') with a hardcoded 'Test' branch reference. This is inconsistent with the pattern used elsewhere in the workflow where INTERFACES_REF is defined as an environment variable (line 17). Hardcoding feature branch names reduces maintainability and can cause failures if the branch doesn't exist. Consider using an environment variable or workflow input for this reference as well.

Suggested change
ref: Test
ref: ${{ env.INTERFACES_REF }}

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch name 'Test' is generic and ambiguous. It doesn't clearly indicate its purpose or relationship to COMRPC changes. Consider using a more descriptive branch name like 'L2TestPlugin_COMRPC' to maintain consistency with the other branch references in this PR.

Suggested change
ref: Test
ref: L2TestPlugin_COMRPC

Copilot uses AI. Check for mistakes.
#token : ${{ secrets.RDKCM_RDKE }}
run: rm -rf $GITHUB_WORKSPACE/entservices-apis/jsonrpc/DTV.json

Expand Down
Loading