-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for COMRPC changes in L2Tests plugin in Testframework repo #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
7434937
0b7158b
4c2bb46
8cb10f7
3458b91
a303428
51900e3
0557338
c814821
7860630
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,7 +123,7 @@ jobs: | |
| with: | ||
| repository: rdkcentral/entservices-testframework | ||
| path: entservices-testframework | ||
| ref: develop | ||
| ref: L2TestPlugin_COMRPC | ||
| token: ${{ secrets.RDKCM_RDKE }} | ||
|
|
||
| - name: Checkout entservices-casting | ||
|
|
@@ -138,7 +138,7 @@ jobs: | |
| with: | ||
| repository: rdkcentral/entservices-casting | ||
| path: entservices-casting | ||
| ref: develop | ||
| ref: L2TestPlugin_COMRPC | ||
|
||
|
|
||
| - name: Checkout googletest | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change hardcodes a feature branch reference instead of using the stable 'develop' branch. Feature branch references in workflow files can cause issues if the branch is deleted, renamed, or if changes are not coordinated across repositories. This appears to be a temporary change for testing purposes. Consider using environment variables or workflow inputs to make this configurable, or document in the PR when these references will be reverted to 'develop'.