Skip to content

RDKEMW-3526 - VRR support Devicesettings #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neethuas379 wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-3526 - VRR support Devicesettings #51

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d20b38
message
Neethu379 Apr 28, 2025
49bf73f
Update dsHdmiIn.c
neethuas379 Apr 29, 2025
3b54d9a
Update dsHdmiIn.c
neethuas379 Apr 29, 2025
d6d98c8
Update hdmiIn.cpp
neethuas379 May 2, 2025
5455986
Update dsHdmiIn.c
neethuas379 May 2, 2025
bf0109d
Update dsHdmiIn.c
neethuas379 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions ds/hdmiIn.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,37 @@ void HdmiInput::getEdidVersion (int iHdmiPort, int *iEdidVersion) {
printf ("%s:%d - EDID Version = %d\n", __PRETTY_FUNCTION__, __LINE__, *iEdidVersion);
}

void HdmiInput::setVRRSupport(int iHdmiPort, bool vrrSupport)
{
printf ("HdmiInput::setVRRSupport \r\n");
Copy link
Contributor

@apatel859 apatel859 Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need two print in same function

dsError_t ret = dsHdmiInSetVRRSupport (static_cast<dsHdmiInPort_t>(iHdmiPort), vrrSupport);
if (ret != dsERR_NONE)
{
throw Exception(ret);
}
printf ("%s:%d - Set VRR Support = %d\n", __PRETTY_FUNCTION__, __LINE__, vrrSupport);
}

void HdmiInput::getVRRSupport (int iHdmiPort, bool *vrrSupport) {
printf ("HdmiInput::getVRRSupport \r\n");
dsError_t ret = dsHdmiInGetVRRSupport (static_cast<dsHdmiInPort_t>(iHdmiPort), vrrSupport);
if (ret != dsERR_NONE)
{
throw Exception(ret);
}
printf ("%s:%d - EDID VRR Support = %d\n", __PRETTY_FUNCTION__, __LINE__, *vrrSupport);
}

void HdmiInput::getVRRStatus (int iHdmiPort, dsVRRType_t *vrrStatus) {
printf ("HdmiInput::getVRRStatus \r\n");
dsError_t ret = dsHdmiInGetVRRStatus (static_cast<dsHdmiInPort_t>(iHdmiPort), vrrStatus);
if (ret != dsERR_NONE)
{
throw Exception(ret);
}
printf ("%s:%d - VRR Status = %d\n", __FUNCTION__, __LINE__, *vrrStatus);
}

void HdmiInput::getHdmiALLMStatus (int iHdmiPort, bool *allmStatus) {
printf ("HdmiInput::getHdmiALLMStatus \r\n");
dsError_t ret = dsGetAllmStatus (static_cast<dsHdmiInPort_t>(iHdmiPort), allmStatus);
Expand Down
3 changes: 3 additions & 0 deletions ds/include/hdmiIn.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ class HdmiInput
void getAVLatency(int *audio_latency,int *video_latency);
void setEdid2AllmSupport(int iHdmiPort,bool allm_suppport);
void getEdid2AllmSupport(int iHdmiPort, bool *allm_support);
void setVRRSupport (int iHdmiPort, bool vrr_suppport);
void getVRRSupport (int iHdmiPort, bool *vrr_suppport);
void getVRRStatus (int iHdmiPort, dsVRRType_t *vrrStatus);
void getHdmiVersion (int iHdmiPort, dsHdmiMaxCapabilityVersion_t *capversion);
private:
HdmiInput (); /* default constructor */
Expand Down
66 changes: 66 additions & 0 deletions rpc/cli/dsHdmiIn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,72 @@ dsError_t dsGetEdid2AllmSupport (dsHdmiInPort_t iHdmiPort, bool *allm_support)
return dsERR_GENERAL;
}

dsError_t dsHdmiInSetVRRSupport (dsHdmiInPort_t iHdmiPort, bool vrr_support)
{
_DEBUG_ENTER();

dsVRRSupportParam_t param;
IARM_Result_t rpcRet = IARM_RESULT_SUCCESS;
param.iHdmiPort = iHdmiPort;
param.vrrSupport = vrr_support;
rpcRet = IARM_Bus_Call (IARM_BUS_DSMGR_NAME,
(char *)IARM_BUS_DSMGR_API_dsSetVRRSupport,
(void *)&param,
sizeof(param));

printf("[cli]: dsSetVRRSupport port :%d, vrrsupport :%d\n",param.iHdmiPort,param.vrrSupport);
Copy link
Contributor

@apatel859 apatel859 Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce logs as we dont need to log at every layer

if (IARM_RESULT_SUCCESS == rpcRet)
{
printf ("[cli] %s: dsSetVRRSupport eRet: %d \r\n", __FUNCTION__, param.result);
return param.result;
}
printf("%s:%d - dsERR_GENERAL\n", __PRETTY_FUNCTION__,__LINE__);
return dsERR_GENERAL;
}

dsError_t dsHdmiInGetVRRSupport (dsHdmiInPort_t iHdmiPort, bool *vrr_support)
{
_DEBUG_ENTER();

dsVRRSupportParam_t param;
IARM_Result_t rpcRet = IARM_RESULT_SUCCESS;
param.iHdmiPort = iHdmiPort;
rpcRet = IARM_Bus_Call (IARM_BUS_DSMGR_NAME,
(char *)IARM_BUS_DSMGR_API_dsGetVRRSupport,
(void *)&param,
sizeof(param));

if (IARM_RESULT_SUCCESS == rpcRet)
{
*vrr_support = param.vrrSupport;
printf ("[cli] %s: dsGetVRRSupport: %d \r\n", __FUNCTION__, param.vrrSupport);
return param.result;
}
printf("%s:%d - dsERR_GENERAL\n", __PRETTY_FUNCTION__,__LINE__);
return dsERR_GENERAL;
}

dsError_t dsHdmiInGetVRRStatus (dsHdmiInPort_t iHdmiPort, dsVRRType_t *vrrStatus)
{
_DEBUG_ENTER();
dsVRRStatusParam_t param;
IARM_Result_t rpcRet = IARM_RESULT_SUCCESS;
param.iHdmiPort = iHdmiPort;
rpcRet = IARM_Bus_Call (IARM_BUS_DSMGR_NAME,
(char *)IARM_BUS_DSMGR_API_dsGetVRRStatus,
(void *)&param,
sizeof(param));

if (IARM_RESULT_SUCCESS == rpcRet)
{
*vrrStatus = param.vrrStatus;
printf ("[cli] %s: dsGetVRRStatus VRR Status: %d \r\n", __FUNCTION__, param.vrrStatus);
return param.result;
}
printf("%s:%d - dsERR_GENERAL\n", __FUNCTION__,__LINE__);
return dsERR_GENERAL;
}

dsError_t dsGetHdmiVersion (dsHdmiInPort_t iHdmiPort, dsHdmiMaxCapabilityVersion_t *capversion)
{
_DEBUG_ENTER();
Expand Down
7 changes: 7 additions & 0 deletions rpc/include/dsMgr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:

Check failure on line 3 in rpc/include/dsMgr.h

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'rpc/include/dsMgr.h' (Match: HariniElangovan890/rdkservices/d73bf6eda46ff140b2d678f5a2eaf3fca1c07bbd, 229 lines, url: https://github.com/HariniElangovan890/rdkservices/archive/d73bf6eda46ff140b2d678f5a2eaf3fca1c07bbd.tar.gz, file: Tests/headers/rdk/ds/dsMgr.h)

Check failure on line 3 in rpc/include/dsMgr.h

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'rpc/include/dsMgr.h' (Match: rdk/components/generic/devicesettings/rdk/components/generic/devicesettings/2012, 141 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/devicesettings/+archive/rdk-dev-2012.tar.gz, file: rpc/include/dsMgr.h)
*
* Copyright 2016 RDK Management
*
Expand Down Expand Up @@ -57,6 +57,7 @@
IARM_BUS_DSMGR_EVENT_HDMI_IN_STATUS, /*!< HDMI IN status change event */
IARM_BUS_DSMGR_EVENT_HDMI_IN_VIDEO_MODE_UPDATE, /*!< HDMI IN video mode update event */
IARM_BUS_DSMGR_EVENT_HDMI_IN_ALLM_STATUS, /*!< HDMI IN ALLM mode update event */
IARM_BUS_DSMGR_EVENT_HDMI_IN_VRR_STATUS, /*!< HDMI IN VRR mode update event */
IARM_BUS_DSMGR_EVENT_COMPOSITE_IN_HOTPLUG, /*!< COMPOSITE IN HPD change event */
IARM_BUS_DSMGR_EVENT_COMPOSITE_IN_SIGNAL_STATUS, /*!< COMPOSITE IN signal status change event */
IARM_BUS_DSMGR_EVENT_COMPOSITE_IN_STATUS, /*!< COMPOSITE IN status change event */
Expand Down Expand Up @@ -86,7 +87,7 @@
dsAUDIOPORT_STATE_MAX
} dsAudioPortState_t;

/*! DS Manager Event Data */

Check failure on line 90 in rpc/include/dsMgr.h

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'rpc/include/dsMgr.h' (Match: rdkcentral/rdkservices/1, 159 lines, url: https://github.com/rdkcentral/rdkservices/archive/GRT_v1.tar.gz, file: Tests/mocks/devicesettings.h)
typedef struct _DSMgr_EventData_t {
union {
struct _RESOLUTION_DATA{
Expand Down Expand Up @@ -230,6 +231,12 @@
bool allm_mode;
}hdmi_in_allm_mode; /*HDMI in ALLM Mode change*/

struct _HDMI_IN_VRR_MODE_DATA{
/* Declare HDMI In VRR Mode*/
dsHdmiInPort_t port;
dsVRRType_t vrr_type;
}hdmi_in_vrr_mode; /*HDMI in VRR Mode change*/

struct _HDMI_IN_CONTENT_TYPE_DATA{
/* Declare HDMI In ALLM Mode*/
dsHdmiInPort_t port;
Expand Down
17 changes: 17 additions & 0 deletions rpc/include/dsRpc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,9 @@ extern "C" {
#define IARM_BUS_DSMGR_API_dsSetEdid2AllmSupport "dsSetEdid2AllmSupport"
#define IARM_BUS_DSMGR_API_dsGetEdid2AllmSupport "dsGetEdid2AllmSupport"
#define IARM_BUS_DSMGR_API_dsGetAllmStatus "dsGetAllmStatus"
#define IARM_BUS_DSMGR_API_dsSetVRRSupport "dsSetVRRSupport"
#define IARM_BUS_DSMGR_API_dsGetVRRSupport "dsGetVRRSupport"
#define IARM_BUS_DSMGR_API_dsGetVRRStatus "dsGetVRRStatus"
#define IARM_BUS_DSMGR_API_dsGetSupportedGameFeaturesList "dsGetSupportedGameFeaturesList"
#define IARM_BUS_DSMGR_API_dsGetAVLatency "dsGetAVLatency"
#define IARM_BUS_DSMGR_API_dsGetHdmiVersion "dsGetHdmiVersion"
Expand Down Expand Up @@ -1009,6 +1012,20 @@ typedef struct _dsEdidAllmSupportParam_t
bool allmSupport;
}dsEdidAllmSupportParam_t;

typedef struct _dsVRRSupportParam_t
{
dsError_t result;
dsHdmiInPort_t iHdmiPort;
bool vrrSupport;
}dsVRRSupportParam_t;

typedef struct _dsVRRStatusParam_t
{
dsError_t result;
dsHdmiInPort_t iHdmiPort;
dsVRRType_t vrrStatus;
}dsVRRStatusParam_t;

typedef struct _dsGetHDMIARCPortIdParam_t {
dsError_t result;
int portId;
Expand Down
Loading
Loading