Open
Conversation
apatel859
reviewed
Apr 29, 2025
ds/hdmiIn.cpp
Outdated
|
|
||
| void HdmiInput::setVRRSupport(int iHdmiPort, bool vrrSupport) | ||
| { | ||
| printf ("HdmiInput::setVRRSupport \r\n"); |
Contributor
There was a problem hiding this comment.
We dont need two print in same function
apatel859
reviewed
Apr 29, 2025
| std::string _VRRSupport("TRUE"); | ||
| try { | ||
| _VRRSupport = device::HostPersistence::getInstance().getProperty("HDMI0.vrrEnable"); | ||
| if(_VRRSupport == "TRUE") |
Contributor
There was a problem hiding this comment.
_VRRSupport is initialized to true so why we checking here for TRUE which will always be the success case
apatel859
reviewed
Apr 29, 2025
rpc/cli/dsHdmiIn.c
Outdated
| (void *)¶m, | ||
| sizeof(param)); | ||
|
|
||
| printf("[cli]: dsSetVRRSupport port :%d, vrrsupport :%d\n",param.iHdmiPort,param.vrrSupport); |
Contributor
There was a problem hiding this comment.
reduce logs as we dont need to log at every layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.