Skip to content

[Feature] [KubeRay Dashboard] hidden the grafana dashboard if link is not provided #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
+34 −30
Merged

[Feature] [KubeRay Dashboard] hidden the grafana dashboard if link is not provided #4094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions dashboard/src/components/ClustersTable/ClustersTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,21 +123,23 @@ export const ClustersTable = () => {
/>
</IconButton>
)}
<IconButton
variant="plain"
size="sm"
sx={{
minHeight: "1rem",
minWidth: "1rem",
px: 0.5,
}}
title="Grafana Metrics"
href={row.links.rayGrafanaDashboardLink}
target="_blank"
component="a"
>
<Image priority src={GrafanaIcon} alt="Grafana Metrics" />
</IconButton>
{row.links.rayGrafanaDashboardLink && (
<IconButton
variant="plain"
size="sm"
sx={{
minHeight: "1rem",
minWidth: "1rem",
px: 0.5,
}}
title="Grafana Metrics"
href={row.links.rayGrafanaDashboardLink}
target="_blank"
component="a"
>
<Image priority src={GrafanaIcon} alt="Grafana Metrics" />
</IconButton>
)}
</td>
</>
);
Expand Down
32 changes: 17 additions & 15 deletions dashboard/src/components/JobsTable/JobsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,21 +120,23 @@ export const JobsTable = () => {
/>
</IconButton>
)}
<IconButton
variant="plain"
size="sm"
sx={{
minHeight: "1rem",
minWidth: "1rem",
px: 0.5,
}}
title="Grafana Metrics"
href={row.links.rayGrafanaDashboardLink}
target="_blank"
component="a"
>
<Image priority src={GrafanaIcon} alt="Grafana Metrics" />
</IconButton>
{row.links.rayGrafanaDashboardLink && (
<IconButton
variant="plain"
size="sm"
sx={{
minHeight: "1rem",
minWidth: "1rem",
px: 0.5,
}}
title="Grafana Metrics"
href={row.links.rayGrafanaDashboardLink}
target="_blank"
component="a"
>
<Image priority src={GrafanaIcon} alt="Grafana Metrics" />
</IconButton>
)}
<IconButton
variant="plain"
size="sm"
Expand Down
Loading