Skip to content

Conversation

CheyuWu
Copy link
Collaborator

@CheyuWu CheyuWu commented Sep 22, 2025

Why are these changes needed?

Spec

In the KubeRay Dashboard, the Grafana icon in the cluster table currently has no functionality if the Grafana link is not configured. This may confuse users since the icon appears clickable but leads nowhere.

Expected Behavior

  • If the Grafana link is not provided, the Grafana icon should be hidden from the dashboard table.

  • If the Grafana link is configured, the icon should remain visible and functional.

Manual Testing

Launch api server and frontend server

$ go run cmd/main.go -httpPortFlag :31888 -cors-allow-origin=*

$ yarn dev

Upload the rayjob sample

$ kubectl apply -f ray-operator/config/samples/ray-job.sample.yaml

Check the rayjob dashboard
image

Check the raycluster dashboard
image

The Grafana Dashboard Icon is not displayed

Related issue number

Closes #4093

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@CheyuWu CheyuWu changed the title [KubeRay Dashboard] hidden the grafana dashboard if link is not provided [Feature] [KubeRay Dashboard] hidden the grafana dashboard if link is not provided Sep 22, 2025
@CheyuWu
Copy link
Collaborator Author

CheyuWu commented Sep 22, 2025

Hi @han-steve, could you please take a look?

@CheyuWu CheyuWu requested a review from Copilot September 22, 2025 16:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements conditional visibility for the Grafana dashboard icon in the KubeRay Dashboard. The icon is now hidden when no Grafana link is configured, improving user experience by avoiding non-functional UI elements.

  • Adds conditional rendering to hide Grafana icons when links are not provided
  • Affects both the Jobs table and Clusters table components
  • Prevents user confusion from non-functional clickable elements

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
dashboard/src/components/JobsTable/JobsTable.tsx Wraps Grafana icon with conditional check for rayGrafanaDashboardLink
dashboard/src/components/ClustersTable/ClustersTable.tsx Wraps Grafana icon with conditional check for rayGrafanaDashboardLink

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rueian rueian merged commit 9bd753c into ray-project:master Sep 30, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] [KubeRay Dashboard] hidden the grafana dashboard if link is not provided
2 participants