Update mbedtls, lwip and cyw43-driver #2405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds some docs for pico_mbedtls Documents the config for overriding the code in pico-sdk/libs
There are some build changes needed for the latest version of mbedtls.
altcp_tls_mbedtls.c is not compatible with mbedtls 3.x so use a patched version until this is resolved. Make sure MBEDTLS_VERSION_MAJOR is visible to LwIP.
peterharperuk
force-pushed
the
update_stuff
branch
from
8bc3d28 to
ba99b4d
Compare
It seems everything needs "no-cast-qual" due to mbedtls_get_unaligned_uint64. Move the source file lists into functions so they can be used in suppress_mbedtls_warnings to add -Wno-cast-qual to just mbedtls source files.
Use it in kitchen_sink
Change for bazel build
Update github workflow to add "--recursive" to "git submodule update --init"
peterharperuk
force-pushed
the
update_stuff
branch
from
adddf8d to
b493ef0
Compare
|
I have tested this with pico-examples (needs this change raspberrypi/pico-examples#631 |
|
what happens if the user hasn't initialized mbedtls` sub-modules? |
Good question. The cmake workflow fails on github. But I think this is just caused by picotool trying to use lib/mbedtls which has a cmake file in lib/mbedtls/framework. So pico-examples builds ok if the submodule is not there. |
|
Cc @will-v-pi |
|
Picotool currently includes mbedtls with |
kilograham
approved these changes
Apr 11, 2025
This was referenced Apr 14, 2025
Closed
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lwip, mbedtls and cyw43-driver
Includes fixes to the build for mbedtls and some docs changes
It seemed less confusing to push all these changes in one PR?