Use Mbedtls files directly #226
Conversation
| @@ -1,6 +1,6 @@ | |||
| cc_library( | |||
| name = "mbedtls_config", | |||
| hdrs = ["include/mbedtls_config.h"], | |||
| hdrs = ["include/mbedtls_config.h", "include/picotool_mbedtls_config.h"], | |||
There was a problem hiding this comment.
Does it make sense to list both of these files, when mbedtls_config.h is merely a wrapper around picotool_mbedtls_config.h ? Or is this a required backwards-compatibility-thing in order not to break any existing Bazel projects? (I'm afraid I don't know much about Bazel!)
There was a problem hiding this comment.
If both are going to be referenced, both need to be added. This is because Bazel sandboxes things, so if a file is not listed it won't be available during compilation.
With that said, this has made me realize that the mbedtls configuration handling is wrong in Bazel, so don't worry too much about it. (you're welcome to file an issue and assign it to me)
|
|
Priority to CMake var, then env var, then default to SDK submodule
will-v-pi
force-pushed
the
mbedtls-direct
branch
from
d40f734 to
f351c6c
Compare
Not required now #226 is merged
Update to a more pico-sdk style inclusion of mbedtls, by including the files directly
Tested against develop (mbedtls 2.x), and raspberrypi/pico-sdk#2405 (mbedtls 3.x)