Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove key #62

Merged
merged 6 commits into from
May 17, 2024
Merged

Remove key #62

merged 6 commits into from
May 17, 2024

Conversation

RossanaTat
Copy link
Collaborator

@RossanaTat RossanaTat commented May 17, 2024 •
edited
Loading

Screenshot 2024-05-16 092515 PR is to remove datatable key after joining with joyn().
--> when executing a joyn::joyn, similarly to collapse, if sort = TRUE, the dt is sorted, if sort = FALSE, the dt is not sorted. In both cases, the resulting dt will never have a key by default so that it is up to the user to set it themselves.

@randrescastaneda randrescastaneda merged commit e3b3475 into DEV May 17, 2024
7 checks passed
@randrescastaneda randrescastaneda deleted the remove_key branch May 17, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randrescastaneda randrescastaneda randrescastaneda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RossanaTat @randrescastaneda