Merge pull request #62 from randrescastaneda:remove_key

Remove key

R/joyn-merge.R

@@ -61,7 +61,7 @@
 #'   will be added to the original name to distinguish from the resulting
 #'   variable in the joined table.
 #' @param  sort logical: If TRUE, sort by key variables in `by`. Default is
-#'   TRUE.
+#'   FALSE.
 #' @param allow.cartesian logical: Check documentation in official [web
 #'   site](https://rdatatable.gitlab.io/data.table/reference/merge.html/).
 #'   Default is `NULL`, which implies that if the join is "1:1" it will be
@@ -166,7 +166,7 @@ joyn <- function(x,
                  reporttype       = c("character", "numeric"),
                  roll             = NULL,
                  keep_common_vars = FALSE,
-                 sort             = TRUE,
+                 sort             = FALSE,
                  verbose          = getOption("joyn.verbose"),
                  suffixes         = getOption("joyn.suffixes"),
                  allow.cartesian  = deprecated(),
@@ -309,7 +309,8 @@ joyn <- function(x,
     y          = y,
     by         = by,
     match_type = match_type,
-    suffixes   = suffixes
+    suffixes   = suffixes,
+    sort       = sort
   )
 
   #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -429,12 +430,6 @@ joyn <- function(x,
                          .xreport = NULL,
                          .yreport = NULL)
 
-
-  if (sort) {
-    setorderv(x, by, na.last = na.last)
-    setattr(x, 'sorted', by)
-  }
-
   ## Rename by variables -----
 
   if (!is.null(fixby$xby)) {

R/joyn_workhorse.R

@@ -10,6 +10,7 @@
 #'   "1:m", "m:1", or "m:m". If "m:m" then executes `data.table::merge.data.table`
 #'   in the backend, otherwise uses `collapse::join()`
 #' @param suffixes atomic character vector: give suffixes to columns common to both
+#' @param sort logical: sort the result by the columns in `by`
 #'   `x` and `y`
 #' @return data object of same class as `x`
 #' @keywords internal
@@ -30,6 +31,7 @@ joyn_workhorse <- function(
     y,
     by         = intersect(names(x), names(y)),
     match_type = c("1:1"),
+    sort       = FALSE,
     suffixes     = getOption("joyn.suffixes") # data.table suffixes
 ) {
 
@@ -80,7 +82,7 @@ joyn_workhorse <- function(
             y               = y,
             by              = by,
             all             = TRUE,
-            sort            = FALSE,
+            sort            = sort,
             suffixes        = suffixes,
             allow.cartesian = TRUE
           )
@@ -94,6 +96,7 @@ joyn_workhorse <- function(
                           validate       = "m:m",    # no checks performed
                           suffix         = suffixes,   # data.table suffixes
                           keep.col.order = TRUE,
+                          sort           = sort,
                           verbose        = 0,
                           column         = NULL)
       }
@@ -132,7 +135,7 @@ joyn_workhorse <- function(
             y               = y,
             by              = by,
             all             = TRUE,
-            sort            = FALSE,
+            sort            = sort,
             suffixes        = suffixes,
             allow.cartesian = TRUE
           ) |>
@@ -147,6 +150,7 @@ joyn_workhorse <- function(
                           validate       = "m:m",    # no checks performed
                           suffix         = suffixes,   # data.table suffixes
                           keep.col.order = TRUE,
+                          sort           = sort,
                           verbose        = 0,
                           column         = NULL)  |>
             suppressWarnings()