Skip to content

fix(theme): light-content / dark-content SCSS rules not included in Reveal.js format #13771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cderv merged 8 commits into from
Dec 12, 2025
Merged

fix(theme): light-content / dark-content SCSS rules not included in Reveal.js format #13771

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f876ba4
fix: `light-content` / `dark-content` SCSS rules not included in Reve…
mcanouil Dec 9, 2025
c105a0e
chore: add changelog entry
mcanouil Dec 9, 2025
66a66d6
refactor: consolidate light/dark content css rules
mcanouil Dec 10, 2025
1eefba9
test: add playwright tests for light/dark-content CSS rules
mcanouil Dec 10, 2025
55ac2cf
refactor: simplify light content visibility checks and remove dark mo…
mcanouil Dec 10, 2025
9c69068
refactor: use helper functions from playwright
mcanouil Dec 11, 2025
044b3ed
Merge branch 'main' into fix/issue13722
mcanouil Dec 11, 2025
42219d0
Merge branch 'main' into fix/issue13722
mcanouil Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions news/changelog-1.9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ All changes included in 1.9:
- ([#13667](https://github.com/quarto-dev/quarto-cli/issues/13667)): Fix LaTeX compilation error with Python error output containing caret characters.
- ([#13730](https://github.com/quarto-dev/quarto-cli/issues/13730)): Fix TinyTeX detection when `~/.TinyTeX/` directory exists without binaries. Quarto now verifies that the bin directory and tlmgr binary exist before reporting TinyTeX as available, allowing proper fallback to system PATH installations.

### `revealjs`

- ([#13722](https://github.com/quarto-dev/quarto-cli/issues/13722)): Improve handling of light and dark content in `revealjs` format. `light-content` and `dark-content` SCSS rules are now included in the proper SCSS file, ensuring proper styling for light and dark modes divs, mostly for multiformat documents. (author: @mcanouil)

## Projects

### `website`
Expand Down
12 changes: 12 additions & 0 deletions src/resources/formats/revealjs/quarto.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,3 +1114,15 @@ $callouts: (
}
}
}

/*********************************************
* LIGHT AND DARK CONTENT
*********************************************/

body.quarto-light .dark-content {
display: none !important;
}

body.quarto-dark .light-content {
display: none !important;
}
12 changes: 0 additions & 12 deletions src/resources/formats/revealjs/reveal/css/reveal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1535,18 +1535,6 @@ $controlsArrowAngleActive: 36deg;
transition-duration: 1200ms;
}

/*********************************************
* LIGHT AND DARK CONTENT
*********************************************/

body.quarto-light .dark-content {
display: none !important;
}

body.quarto-dark .light-content {
display: none !important;
}

/*********************************************
* OVERLAY FOR LINK PREVIEWS AND HELP
*********************************************/
Expand Down
Loading