Skip to content

fix(theme): light-content / dark-content SCSS rules not included in Reveal.js format #13771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mcanouil wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(theme): light-content / dark-content SCSS rules not included in Reveal.js format #13771

mcanouil wants to merge 7 commits into from
+125 −20

Conversation

@mcanouil
Copy link
Collaborator

@mcanouil mcanouil commented Dec 9, 2025 •
edited
Loading

Move the light-content / dark-content SCSS rules to the right SCCS file.

Fixes #13722

@mcanouil mcanouil self-assigned this Dec 9, 2025
@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Dec 9, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

cderv
cderv reviewed Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts and context about how theming system works in Quarto and where it could be place.

This PR needs testing too.

(and yes I know this is not marked for review, but I was in PR review mode and it was not draft 😅 )

@mcanouil mcanouil marked this pull request as draft December 9, 2025 12:51
@mcanouil mcanouil marked this pull request as ready for review December 10, 2025 20:49
@mcanouil
Copy link
Collaborator Author

mcanouil commented Dec 10, 2025 •
edited
Loading

I've made the changes, but how can you test that compiled SCSS rules get included in the output? ensureHtmlElements only check the HTML and if embed-ressources is used, you still don't have a literal string to search in.

edit: I figured it out, there is a playwright testing suite.

@mcanouil mcanouil marked this pull request as draft December 10, 2025 21:56
@mcanouil
refactor: simplify light content visibility checks and remove dark mo…
55ac2cf 
…de tests as revealjs does not support dark mode
@mcanouil mcanouil marked this pull request as ready for review December 10, 2025 22:18
@mcanouil mcanouil changed the title fix: light-content / dark-content SCSS rules not included in Reveal.js format fix(theme): light-content / dark-content SCSS rules not included in Reveal.js format Dec 10, 2025
cderv
cderv reviewed Dec 11, 2025
View reviewed changes
@mcanouil mcanouil marked this pull request as draft December 11, 2025 10:18
@mcanouil mcanouil marked this pull request as ready for review December 11, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cderv cderv cderv left review comments

Assignees

@mcanouil mcanouil

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

light-content / dark-content SCSS rules not included in Reveal.js format

3 participants

@mcanouil @posit-snyk-bot @cderv