Wheels macos #379
Merged
Wheels macos #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It looks like this PR only handles the release workflow. Is the intent to rely on the existing Kokoro pipeline for verifying the MacOS build on pull requests?
Given that we'll need Kokoro for testing GPU and AVX512 builds regardless, this would be a valid choice - just want to confirm.
|
@95-martin-orion I added two separate workflows for building the wheels, one for releases with the upload to the PyPI and the other for PRs and merges to master for testing purposes. Is that what you expected? |
95-martin-orion
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a cross-platform wheels issue and adds support for building and uploading MacOS wheels for cp36, cp37, cp38, cp39 on x86_64 architecture.